Skip to content

Commit 8cd7b07

Browse files
fix notifications logo
1 parent 7741716 commit 8cd7b07

File tree

4 files changed

+21
-3
lines changed

4 files changed

+21
-3
lines changed

api/providers/serializers.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
from osf.models.user import Email, OSFUser
1515
from osf.models.validators import validate_email
1616
from osf.utils.permissions import REVIEW_GROUPS, ADMIN
17-
from website.settings import DOMAIN
17+
from website.settings import DOMAIN, OSF_PREPRINTS_LOGO
1818

1919

2020
class ProviderSerializer(JSONAPISerializer):
@@ -365,6 +365,11 @@ def create(self, validated_data):
365365
context['is_reviews_moderator_notification'] = True
366366
context['is_admin'] = perm_group == ADMIN
367367
context['provider_url'] = f'{provider.domain or DOMAIN}preprints/{(provider._id if not provider.domain else '').strip('/')}',
368+
if provider._id == 'osf':
369+
logo = OSF_PREPRINTS_LOGO
370+
else:
371+
logo = provider._id
372+
context['logo'] = logo
368373

369374
provider.add_to_group(user, perm_group)
370375
setattr(user, 'permission_group', perm_group) # Allows reserialization

notifications/tasks.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,8 @@ def send_moderator_email_task(self, user_id, notification_ids, **kwargs):
163163
'reviews_submissions_url': submissions_url,
164164
'provider_type': provider_type,
165165
'additional_context': additional_context,
166-
'is_admin': provider.get_group(ADMIN).user_set.filter(id=user.id).exists()
166+
'is_admin': provider.get_group(ADMIN).user_set.filter(id=user.id).exists(),
167+
'logo': provider._id if not provider.is_default else settings.OSF_PREPRINTS_LOGO,
167168
}
168169

169170
NotificationType.Type.DIGEST_REVIEWS_MODERATORS.instance.emit(

osf/email/__init__.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,8 @@ def _read_lookup_uri(uri: str) -> str:
143143
'ns_url': '',
144144
'osf_contact_email': settings.OSF_CONTACT_EMAIL,
145145
'provider_name': '',
146+
'osf_logo_list': settings.OSF_LOGO_LIST,
147+
'OSF_LOGO_LIST': settings.OSF_LOGO_LIST,
146148
}
147149

148150
def _render_email_html(notification_type, ctx: dict) -> str:

osf/models/collection_submission.py

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,9 @@ def _notify_moderators_pending(self, event_data):
148148
'reviews_submission_url': f'{DOMAIN}reviews/registries/{self.guid.referent._id}/{self.guid.referent._id}',
149149
'is_request_email': False,
150150
'is_initiator': self.creator == user,
151-
'profile_image_url': user.profile_image_url()
151+
'profile_image_url': user.profile_image_url(),
152+
'logo': self.collection.provider._id if
153+
self.collection.provider and not self.collection.provider.is_default else settings.OSF_PREPRINTS_LOGO,
152154
},
153155
is_digest=True,
154156
)
@@ -189,6 +191,8 @@ def _notify_accepted(self, event_data):
189191
'domain': settings.DOMAIN,
190192
'osf_contact_email': settings.OSF_CONTACT_EMAIL,
191193
'is_initiator': self.creator == contributor,
194+
'logo': self.collection.provider._id if
195+
self.collection.provider and not self.collection.provider.is_default else settings.OSF_PREPRINTS_LOGO,
192196
},
193197
)
194198

@@ -228,6 +232,8 @@ def _notify_moderated_rejected(self, event_data):
228232
'reviews_submission_url': f'{DOMAIN}reviews/registries/{self.guid.referent._id}/{self.guid.referent._id}',
229233
'rejection_justification': event_data.kwargs.get('comment'),
230234
'osf_contact_email': settings.OSF_CONTACT_EMAIL,
235+
'logo': self.collection.provider._id if
236+
self.collection.provider and not self.collection.provider.is_default else settings.OSF_PREPRINTS_LOGO,
231237
},
232238
)
233239

@@ -271,6 +277,8 @@ def _notify_removed(self, event_data):
271277
'profile_image_url': user.profile_image_url(),
272278
'domain': settings.DOMAIN,
273279
'osf_contact_email': settings.OSF_CONTACT_EMAIL,
280+
'logo': self.collection.provider._id if
281+
self.collection.provider and not self.collection.provider.is_default else settings.OSF_PREPRINTS_LOGO,
274282
}
275283

276284
if removed_due_to_privacy and self.collection.provider:
@@ -405,6 +413,8 @@ def _notify_cancel(self, event_data):
405413
'message': '',
406414
'osf_contact_email': settings.OSF_CONTACT_EMAIL,
407415
'reviews_submission_url': f'{DOMAIN}reviews/registries/{self.guid.referent._id}/{self.guid.referent._id}',
416+
'logo': self.collection.provider._id if
417+
self.collection.provider and not self.collection.provider.is_default else settings.OSF_PREPRINTS_LOGO,
408418
},
409419
)
410420

0 commit comments

Comments
 (0)