Skip to content

quick_feedback is async but has no await #13

Description

@DeFiVC

What

The quick_feedback method is declared async def but performs only synchronous string operations and comparisons. It contains no await calls.

Why

Marking it async adds unnecessary coroutine overhead and forces callers to await it. This also means the tests use @pytest.mark.asyncio for what is effectively a synchronous test.

Scope

  • Remove async from the method

Acceptance Criteria

  • The method is synchronous

Technical Context

  • File: src/services/feedback_engine.py, line 98

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions