chore: remove unneeded changes

Author: EclesioMeloJunior

scripts/tests/external-rpc-checks/docker-compose.yaml

@@ -9,15 +9,6 @@ x-forest-service: &forest-service
     - FOREST_PATH=/data
   user: 0:0
 
-# Talks to the node from inside the compose network, so its RPC port is never published.
-x-rpc-client: &rpc-client
-  image: ghcr.io/chainsafe/forest-rpc-checks:latest
-  depends_on:
-    forest:
-      condition: service_healthy
-  environment:
-    FOREST_RPC_URL: forest:${FOREST_RPC_PORT}/rpc/v1
-
 services:
   resolve:
     image: ghcr.io/chainsafe/forest-rpc-checks:latest
@@ -64,16 +55,12 @@ services:
       start_period: 5m
       start_interval: 5s
 
-  # Waits for the node to sync past the day the checks cover.
-  wait:
-    <<: *rpc-client
-    volumes:
-      - ./wait.rb:/wait.rb:ro
-    entrypoint: ["ruby", "/wait.rb"]
-
   # Probes the node for the epochs the checks are about to query.
   verify:
-    <<: *rpc-client
+    image: ghcr.io/chainsafe/forest-rpc-checks:latest
+    depends_on:
+      forest:
+        condition: service_healthy
     volumes:
       - ./verify.rb:/verify.rb:ro
     entrypoint: ["ruby", "/verify.rb"]

scripts/tests/external-rpc-checks/resolve.rb

@@ -1,11 +1,9 @@
 # frozen_string_literal: true
 
-# Picks the ${FOREST_CHAIN} snapshot the checks start from and records under /data its URL,
-# its head epoch, and the chain plus the epoch range of the UTC day DAYS_AGO days ago, which
-# is what the dataset's daily archives cover.
-#
-# The archive's snapshots carry the state of their last 2000 epochs and the index backfill
-# re-executes every epoch down and the node syncs the rest upwards (see ./wait.rb).
+# Picks the ${FOREST_CHAIN} snapshot published DAYS_AGO days ago (UTC), by the date in its name,
+# and records under /data what the rest of the harness needs: its URL, its head epoch, and the
+# chain plus the ${FOREST_CHECK_EPOCHS}-epoch range the checks cover.
+# Runs in the checks image, which has Ruby, so the Forest image needs no curl.
 
 require 'date'
 require 'json'

scripts/tests/external-rpc-checks/setup.sh

@@ -10,14 +10,15 @@ pushd "${PARENT_PATH}"
 # This should not be needed in GH. It is useful for running locally.
 docker compose down --remove-orphans --volumes
 
-# Resolves the snapshot and probes the dataset for DAYS_AGO. Sets CHAIN,
-# START and END on success; returns 2 after saying what that day lacks.
+# Resolves the snapshot and probes the dataset for DAYS_AGO. 
+# Sets CHAIN, START and END on success.
+# Returns 2 on failure
 check_day() {
   local status=0
   docker compose run --rm --env DAYS_AGO="$1" resolve || status=$?
   case ${status} in
     0) ;;
-    2) return 2 ;; # resolve said why
+    2) return 2 ;;
     *) exit "${status}" ;;
   esac