Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement self rate-limiting #3344

Open
dapplion opened this issue Oct 8, 2021 · 3 comments
Open

Implement self rate-limiting #3344

dapplion opened this issue Oct 8, 2021 · 3 comments
Labels
prio-low This is nice to have. scope-networking All issues related to networking, gossip, and libp2p.

Comments

@dapplion
Copy link
Contributor

dapplion commented Oct 8, 2021 •
edited
Loading

Describe the bug

In merge-interop Teku constantly bans us due to rate-limiting. Teku self rate limits and we should do so with some sane params taken from other clients. Causes #2622

Expected behavior

Prevent rate limiting when connected to few peers
@twoeths twoeths mentioned this issue Nov 23, 2021
Merged
@twoeths twoeths self-assigned this Dec 14, 2021
@twoeths
Copy link
Contributor

twoeths commented Jan 6, 2022

Got this in Prater at the non-finality time:

beacon-2022-01-06.log:623:Jan-06 00:04:35.885 [NETWORK]       verbose: Req  error method=beacon_blocks_by_root, encoding=ssz_snappy, client=Prysm, peer=16...3rfnWg, requestId=1766 code=RESPONSE_STATUS_ERROR, status=1, errorMessage=sNaPpYuV~2rate limited

@twoeths
Copy link
Contributor

twoeths commented May 4, 2022

Refer to ethereum/consensus-specs#2690

@dapplion dapplion added the prio-low This is nice to have. label May 4, 2022
@philknows philknows added the scope-networking All issues related to networking, gossip, and libp2p. label May 5, 2022
@philknows
Copy link
Member

If we spam other nodes, it'll eventually work itself out. Low priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prio-low This is nice to have. scope-networking All issues related to networking, gossip, and libp2p.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@twoeths @dapplion @philknows