Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support old finalized checkpoints in assertPeerRelevance #3412

Open
dapplion opened this issue Nov 4, 2021 · 1 comment
Open

Support old finalized checkpoints in assertPeerRelevance #3412

dapplion opened this issue Nov 4, 2021 · 1 comment
Labels
prio-low This is nice to have.

Comments

@dapplion
Copy link
Contributor

dapplion commented Nov 4, 2021

From #3405

TODO: If the slot is very old, go to the historical blocks DB and fetch the block with less or equal slot. Note that our db schema will have to be updated to persist the block root to prevent re-hashing. For now peers will be accepted, since it's better than throwing an error on getBlockRootAtSlot()

// TODO: If the slot is very old, go to the historical blocks DB and fetch the block with less or equal `slot`.
// Note that our db schema will have to be updated to persist the block root to prevent re-hashing.
// For now peers will be accepted, since it's better than throwing an error on `getBlockRootAtSlot()`

@dapplion dapplion added the prio-medium Resolve this some time soon (tm). label Nov 4, 2021
@philknows
Copy link
Member

Low priority. Find the permalink reference in the code and potentially close @wemeetagain

@philknows philknows added prio-low This is nice to have. and removed prio-medium Resolve this some time soon (tm). labels Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio-low This is nice to have.
Projects
None yet
Development

No branches or pull requests

2 participants