Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent circular dependencies with eslint #3929

Open
dapplion opened this issue Apr 16, 2022 · 3 comments
Open

Prevent circular dependencies with eslint #3929

dapplion opened this issue Apr 16, 2022 · 3 comments
Labels
prio-low This is nice to have. scope-devex Issues for improving developer experience.

Comments

@dapplion
Copy link
Contributor

Motivation

'import/no-cycle' is expensive computationally, consider restricting its maxdepth

See https://github.com/import-js/eslint-plugin-import/blob/HEAD/docs/rules/no-cycle.md#maxdepth

A lint run in master currently takes Done in 121.30s. in Github Actions (from https://github.com/ChainSafe/lodestar/runs/5137987474?check_suite_focus=true#step:13:38)

In this PR for a failed run it took in 137.5s so the extra time is okay 👍

Description

Prevent circular dependencies with eslint

See #3742 for an example implementation

@philknows
Copy link
Member

Related to #6011

@philknows philknows added the scope-devex Issues for improving developer experience. label Nov 29, 2023
@wemeetagain
Copy link
Member

@nazarhussain is there a biome rule?

@nazarhussain
Copy link
Contributor

Not at the moment, but hopefully something related to Analyzer will sure come soon.
https://biomejs.dev/analyzer/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio-low This is nice to have. scope-devex Issues for improving developer experience.
Projects
None yet
Development

No branches or pull requests

4 participants