Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-subscribe all gossip when reverting to finalized sync #4015

Open
1 task
dapplion opened this issue May 12, 2022 · 3 comments
Open
1 task

Un-subscribe all gossip when reverting to finalized sync #4015

dapplion opened this issue May 12, 2022 · 3 comments
Assignees
Labels
prio-medium Resolve this some time soon (tm). scope-performance Performance issue and ideas to improve performance.

Comments

@dapplion
Copy link
Contributor

Currently we un-subscribe core topics when going to finalized sync

this.logger.warn(`Node sync has fallen behind by ${syncDiff} slots`);
this.network.unsubscribeGossipCoreTopics();

However we keep subnet subscriptions, which are actually the ones taking the bulk of CPU processing.

  • Un-subscribe all gossip when reverting to finalized sync

From #2488

@dapplion dapplion added prio-medium Resolve this some time soon (tm). scope-performance Performance issue and ideas to improve performance. labels May 12, 2022
@philknows
Copy link
Member

Please investigate @tuyennhv , this may already be completed.

@wemeetagain
Copy link
Member

This has not been completed, still a real feature request

@twoeths
Copy link
Contributor

twoeths commented Oct 11, 2024

will look into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio-medium Resolve this some time soon (tm). scope-performance Performance issue and ideas to improve performance.
Projects
None yet
Development

No branches or pull requests

4 participants