Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e tests for getBlobSidecars in beacon-chain #5965

Open
nazarhussain opened this issue Sep 18, 2023 · 0 comments
Open

Add e2e tests for getBlobSidecars in beacon-chain #5965

nazarhussain opened this issue Sep 18, 2023 · 0 comments
Labels
prio-low This is nice to have. scope-testing Issues for adding test coverage, fixing existing tests or testing strategies.

Comments

@nazarhussain
Copy link
Contributor

There is a test file which have only one test which is skipped. It would be better to have an issue for tracking it rather the code comment.

// TODO: Write actual tests against the real BeaconChain class, this test is useless
it.skip("getBlobSideCar From BlobSidecars", async () => {
const block = config.getForkTypes(GENESIS_SLOT).SignedBeaconBlock.defaultValue();
const blobSidecars = ssz.deneb.BlobSidecars.defaultValue();
const wrappedBlobSidecars = {
blockRoot: ssz.Root.defaultValue(),
slot: block.message.slot,
blobSidecars,
};
server.forkChoiceStub.getFinalizedBlock.returns(zeroProtoBlock);
server.dbStub.blockArchive.get.resolves(block);
server.dbStub.blobSidecars.get.resolves(wrappedBlobSidecars);
const returnedBlobSideCars = await server.blockApi.getBlobSidecars("genesis");
expect(returnedBlobSideCars.data).to.equal(blobSidecars);
});

@philknows philknows added prio-low This is nice to have. scope-testing Issues for adding test coverage, fixing existing tests or testing strategies. labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio-low This is nice to have. scope-testing Issues for adding test coverage, fixing existing tests or testing strategies.
Projects
None yet
Development

No branches or pull requests

2 participants