Resubscribe to beacon subnets if current epoch dependent root changed

[nflaig]

Describe the bug

We have this function handleAttesterDutiesReorg which is mostly called when head (onNewHead) is updated

• and dependent root for next epoch changed
• or dependent root for current epoch changed

lodestar/packages/validator/src/services/attestationDuties.ts

Line 348 in 1aa6561

private async handleAttesterDutiesReorg(

In both those cases we handle the reorg by

• getting updated attestater duties (getAttesterDuties)
• update cached duties (dutiesByIndexByEpoch)
• recalculate proof (is_aggregator)

But I noticed we are not resubscribing to beacon subnets (prepareBeaconCommitteeSubnet). This is not an issue if the dependent root for the next epoch changed as we re-/subscribe to current (N) and next epoch (N+1) at the start of each epoch.

lodestar/packages/validator/src/services/attestationDuties.ts

Line 196 in 1aa6561

for (const epoch of [currentEpoch, nextEpoch]) {

However, this is an issue if dependent root for current epoch changed as previous subscriptions are no longer valid

• validator duties changed (slot, committee index, etc.)
• is_aggregator results are different

Expected behavior

Validators should be resubscribed to beacon committee subnets if current epoch dependent root changed.

Ideally, should just always resubscribe when handleAttesterDutiesReorg is called even if dependent root for next epoch changed as the subscriptions for epoch N+1 are outdated as well and the sooner we subscribe to subnets, the more likely it is to find good peers.

Steps to reproduce

No response

Additional context

No response

Operating system

Linux

Lodestar version or commit hash

v1.11.3 / unstable (1aa6561)