modify: number로의 형 변환을 서비스 계층에서 수행하도록 수정

Author: ooheunda

src/repositories/__test__/leaderboard.repo.integration.test.ts

@@ -86,7 +86,7 @@ describe('LeaderboardRepository 통합 테스트', () => {
   });
 
   describe('getUserLeaderboard', () => {
-    it('사용자 통계 배열로 이루어진 리더보드를 반환해야 한다', async () => {
+    it('사용자 통계 배열로 이루어진 리더보드를 반환해야 하며, 통계 값은 음수가 아니어야 한다', async () => {
       const result = await repo.getUserLeaderboard(
         DEFAULT_PARAMS.USER_SORT,
         DEFAULT_PARAMS.DATE_RANGE,
@@ -98,14 +98,14 @@ describe('LeaderboardRepository 통합 테스트', () => {
       if (!isEnoughData(result, 1, '사용자 리더보드 반환값')) return;
 
       result.forEach((leaderboardUser) => {
-        expect(typeof leaderboardUser.id).toEqual('string');
-        expect(typeof leaderboardUser.email).toEqual('string');
-        expect(typeof leaderboardUser.total_views).toEqual('number');
-        expect(typeof leaderboardUser.total_likes).toEqual('number');
-        expect(typeof leaderboardUser.total_posts).toEqual('number');
-        expect(typeof leaderboardUser.view_diff).toEqual('number');
-        expect(typeof leaderboardUser.like_diff).toEqual('number');
-        expect(typeof leaderboardUser.post_diff).toEqual('number');
+        expect(leaderboardUser).toHaveProperty('id');
+        expect(leaderboardUser).toHaveProperty('email');
+        expect(leaderboardUser).toHaveProperty('total_views');
+        expect(leaderboardUser).toHaveProperty('total_likes');
+        expect(leaderboardUser).toHaveProperty('total_posts');
+        expect(leaderboardUser).toHaveProperty('view_diff');
+        expect(leaderboardUser).toHaveProperty('like_diff');
+        expect(leaderboardUser).toHaveProperty('post_diff');
       });
     });
 
@@ -119,12 +119,12 @@ describe('LeaderboardRepository 통합 테스트', () => {
       if (!isEnoughData(result, 1, '사용자 리더보드 반환값')) return;
 
       result.forEach((leaderboardUser) => {
-        expect(leaderboardUser.total_views).toBeGreaterThanOrEqual(0);
-        expect(leaderboardUser.total_likes).toBeGreaterThanOrEqual(0);
-        expect(leaderboardUser.total_posts).toBeGreaterThanOrEqual(0);
-        expect(leaderboardUser.view_diff).toBeGreaterThanOrEqual(0);
-        expect(leaderboardUser.like_diff).toBeGreaterThanOrEqual(0);
-        expect(leaderboardUser.post_diff).toBeGreaterThanOrEqual(0);
+        expect(Number(leaderboardUser.total_views)).toBeGreaterThanOrEqual(0);
+        expect(Number(leaderboardUser.total_likes)).toBeGreaterThanOrEqual(0);
+        expect(Number(leaderboardUser.total_posts)).toBeGreaterThanOrEqual(0);
+        expect(Number(leaderboardUser.view_diff)).toBeGreaterThanOrEqual(0);
+        expect(Number(leaderboardUser.like_diff)).toBeGreaterThanOrEqual(0);
+        expect(Number(leaderboardUser.post_diff)).toBeGreaterThanOrEqual(0);
       });
     });
 
@@ -144,7 +144,7 @@ describe('LeaderboardRepository 통합 테스트', () => {
 
         const isSorted = result.every((leaderboardUser, idx) => {
           if (idx === 0) return true;
-          return leaderboardUser[field] <= result[idx - 1][field];
+          return Number(leaderboardUser[field]) <= Number(result[idx - 1][field]);
         });
 
         expect(isSorted).toBe(true);
@@ -233,14 +233,14 @@ describe('LeaderboardRepository 통합 테스트', () => {
       if (!isEnoughData(result, 1, '게시물 리더보드 반환값')) return;
 
       result.forEach((leaderboardPost) => {
-        expect(typeof leaderboardPost.id).toEqual('string');
-        expect(typeof leaderboardPost.title).toEqual('string');
-        expect(typeof leaderboardPost.slug).toEqual('string');
-        expect(typeof leaderboardPost.total_views).toEqual('number');
-        expect(typeof leaderboardPost.total_likes).toEqual('number');
-        expect(typeof leaderboardPost.view_diff).toEqual('number');
-        expect(typeof leaderboardPost.like_diff).toEqual('number');
-        expect(typeof leaderboardPost.released_at).toEqual('object');
+        expect(leaderboardPost).toHaveProperty('id');
+        expect(leaderboardPost).toHaveProperty('title');
+        expect(leaderboardPost).toHaveProperty('slug');
+        expect(leaderboardPost).toHaveProperty('total_views');
+        expect(leaderboardPost).toHaveProperty('total_likes');
+        expect(leaderboardPost).toHaveProperty('view_diff');
+        expect(leaderboardPost).toHaveProperty('like_diff');
+        expect(leaderboardPost).toHaveProperty('released_at');
       });
     });
 
@@ -254,10 +254,10 @@ describe('LeaderboardRepository 통합 테스트', () => {
       if (!isEnoughData(result, 1, '게시물 리더보드 반환값')) return;
 
       result.forEach((leaderboardPost) => {
-        expect(leaderboardPost.total_views).toBeGreaterThanOrEqual(0);
-        expect(leaderboardPost.total_likes).toBeGreaterThanOrEqual(0);
-        expect(leaderboardPost.view_diff).toBeGreaterThanOrEqual(0);
-        expect(leaderboardPost.like_diff).toBeGreaterThanOrEqual(0);
+        expect(Number(leaderboardPost.total_views)).toBeGreaterThanOrEqual(0);
+        expect(Number(leaderboardPost.total_likes)).toBeGreaterThanOrEqual(0);
+        expect(Number(leaderboardPost.view_diff)).toBeGreaterThanOrEqual(0);
+        expect(Number(leaderboardPost.like_diff)).toBeGreaterThanOrEqual(0);
       });
     });
 
@@ -276,7 +276,7 @@ describe('LeaderboardRepository 통합 테스트', () => {
 
         const isSorted = result.every((leaderboardPost, idx) => {
           if (idx === 0) return true;
-          return leaderboardPost[field] <= result[idx - 1][field];
+          return Number(leaderboardPost[field]) <= Number(result[idx - 1][field]);
         });
 
         expect(isSorted).toBe(true);

src/services/__test__/leaderboard.service.test.ts

@@ -30,22 +30,22 @@ describe('LeaderboardService', () => {
         {
           id: '1',
           email: '[email protected]',
-          total_views: 100,
-          total_likes: 50,
-          total_posts: 1,
-          view_diff: 20,
-          like_diff: 10,
-          post_diff: 1,
+          total_views: '100',
+          total_likes: '50',
+          total_posts: '1',
+          view_diff: '20',
+          like_diff: '10',
+          post_diff: '1',
         },
         {
           id: '2',
           email: '[email protected]',
-          total_views: 200,
-          total_likes: 100,
-          total_posts: 2,
-          view_diff: 10,
-          like_diff: 5,
-          post_diff: 1,
+          total_views: '200',
+          total_likes: '100',
+          total_posts: '2',
+          view_diff: '10',
+          like_diff: '5',
+          post_diff: '1',
         },
       ];
 
@@ -121,20 +121,20 @@ describe('LeaderboardService', () => {
           id: '1',
           title: 'test',
           slug: 'test-slug',
-          total_views: 100,
-          total_likes: 50,
-          view_diff: 20,
-          like_diff: 10,
+          total_views: '100',
+          total_likes: '50',
+          view_diff: '20',
+          like_diff: '10',
           released_at: '2025-01-01',
         },
         {
           id: '2',
           title: 'test2',
           slug: 'test2-slug',
-          total_views: 200,
-          total_likes: 100,
-          view_diff: 10,
-          like_diff: 5,
+          total_views: '200',
+          total_likes: '100',
+          view_diff: '10',
+          like_diff: '5',
           released_at: '2025-01-02',
         },
       ];

src/services/leaderboard.service.ts

@@ -42,12 +42,12 @@ export class LeaderboardService {
     const users = rawResult.map((user) => ({
       id: user.id,
       email: user.email,
-      totalViews: user.total_views,
-      totalLikes: user.total_likes,
-      totalPosts: user.total_posts,
-      viewDiff: user.view_diff,
-      likeDiff: user.like_diff,
-      postDiff: user.post_diff,
+      totalViews: Number(user.total_views),
+      totalLikes: Number(user.total_likes),
+      totalPosts: Number(user.total_posts),
+      viewDiff: Number(user.view_diff),
+      likeDiff: Number(user.like_diff),
+      postDiff: Number(user.post_diff),
     }));
 
     return { users };
@@ -58,10 +58,10 @@ export class LeaderboardService {
       id: post.id,
       title: post.title,
       slug: post.slug,
-      totalViews: post.total_views,
-      totalLikes: post.total_likes,
-      viewDiff: post.view_diff,
-      likeDiff: post.like_diff,
+      totalViews: Number(post.total_views),
+      totalLikes: Number(post.total_likes),
+      viewDiff: Number(post.view_diff),
+      likeDiff: Number(post.like_diff),
       releasedAt: post.released_at,
     }));
 
@@ -73,20 +73,20 @@ interface RawPostResult {
   id: string;
   title: string;
   slug: string;
-  total_views: number;
-  total_likes: number;
-  view_diff: number;
-  like_diff: number;
+  total_views: string;
+  total_likes: string;
+  view_diff: string;
+  like_diff: string;
   released_at: string;
 }
 
 interface RawUserResult {
   id: string;
   email: string;
-  total_views: number;
-  total_likes: number;
-  total_posts: number;
-  view_diff: number;
-  like_diff: number;
-  post_diff: number;
+  total_views: string;
+  total_likes: string;
+  total_posts: string;
+  view_diff: string;
+  like_diff: string;
+  post_diff: string;
 }