Make document Id available again in ParseDocument diagnostic event (#8760)

Author: tobias-tengler

src/HotChocolate/Core/src/Execution.Pipeline/DocumentParserMiddleware.cs

@@ -45,6 +45,12 @@ public async ValueTask InvokeAsync(RequestContext context)
             {
                 documentInfo.Hash = CreateDocumentHash(documentInfo, context.Request);
                 documentInfo.Document = parsed.Document;
+
+                if (documentInfo.Id.IsEmpty)
+                {
+                    documentInfo.Id = new OperationDocumentId(documentInfo.Hash.Value);
+                }
+
                 success = true;
             }
             else if (query is OperationDocumentSourceText source)
@@ -55,6 +61,12 @@ public async ValueTask InvokeAsync(RequestContext context)
                     {
                         documentInfo.Hash = CreateDocumentHash(documentInfo, context.Request);
                         documentInfo.Document = Utf8GraphQLParser.Parse(source.SourceText, _parserOptions);
+
+                        if (documentInfo.Id.IsEmpty)
+                        {
+                            documentInfo.Id = new OperationDocumentId(documentInfo.Hash.Value);
+                        }
+
                         success = true;
                     }
                     catch (SyntaxException ex)
@@ -80,11 +92,6 @@ public async ValueTask InvokeAsync(RequestContext context)
 
             if (success)
             {
-                if (documentInfo.Id.IsEmpty)
-                {
-                    documentInfo.Id = new OperationDocumentId(documentInfo.Hash.Value);
-                }
-
                 await _next(context).ConfigureAwait(false);
             }
         }

website/src/docs/hotchocolate/v16/migrating/migrate-from-15-to-16.md

@@ -36,6 +36,36 @@ builder.Services.AddGraphQLServer()
     });
 ```
 
+## IRequestContext
+
+We've removed the `IRequestContext` abstraction in favor of the concrete `RequestContext` class.
+Additionally, all information related to the parsed operation document has been consolidated into a new `OperationDocumentInfo` class, accessible via `RequestContext.OperationDocumentInfo`.
+
+| Before                      | After                                     |
+| --------------------------- | ----------------------------------------- |
+| context.DocumentId          | context.OperationDocumentInfo.Id.Value    |
+| context.Document            | context.OperationDocumentInfo.Document    |
+| context.DocumentHash        | context.OperationDocumentInfo.Hash.Value  |
+| context.ValidationResult    | context.OperationDocumentInfo.IsValidated |
+| context.IsCachedDocument    | context.OperationDocumentInfo.IsCached    |
+| context.IsPersistedDocument | context.OperationDocumentInfo.IsPersisted |
+
+Here's how you would update a custom request middleware implementation:
+
+```diff
+public class CustomRequestMiddleware
+{
+-   public async ValueTask InvokeAsync(IRequestContext context)
++   public async ValueTask InvokeAsync(RequestContext context)
+    {
+-       string documentId = context.DocumentId;
++       string documentId = context.OperationDocumentInfo.Id.Value;
+
+        await _next(context).ConfigureAwait(false);
+    }
+}
+```
+
 ## Skip/include disallowed on root subscription fields
 
 The `@skip` and `@include` directives are now disallowed on root subscription fields, as specified in the RFC: [Prevent @skip and @include on root subscription selection set](https://github.com/graphql/graphql-spec/pull/860).