Skip to content

Commit 7b2bbae

Browse files
committed
removed forEach from service and users.
1 parent 7522d00 commit 7b2bbae

2 files changed

Lines changed: 6 additions & 7 deletions

File tree

adwords/service.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,9 @@ class AdwordsService {
3131
* @param methods {array} an array of string method names
3232
*/
3333
registerServiceDescriptorMethods(methods) {
34-
for (var index in methods) {
35-
var method = methods[index];
34+
_.each(methods, (method) => {
3635
this[method] = this.callServiceMethod(method);
37-
}
36+
});
3837
}
3938

4039
/**

adwords/user.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,11 +60,11 @@ class AdwordsUser {
6060
*/
6161
populateServiceDescriptor(serviceDescriptor, adwordsVersion) {
6262
var finalServiceDescriptor = _.clone(serviceDescriptor);
63-
for (var index in finalServiceDescriptor) {
64-
if ('string' === typeof finalServiceDescriptor[index]) {
65-
finalServiceDescriptor[index] = finalServiceDescriptor[index].replace(/\{\{version\}\}/g, adwordsVersion);
63+
_.each(finalServiceDescriptor, (value, index) => {
64+
if ('string' === typeof value) {
65+
finalServiceDescriptor[index] = value.replace(/\{\{version\}\}/g, adwordsVersion);
6666
}
67-
}
67+
})
6868
return finalServiceDescriptor;
6969
}
7070

0 commit comments

Comments
 (0)