Skip to content

Commit a475c17

Browse files
committed
fix: un-def eslint error for global variables
1 parent a1c630e commit a475c17

File tree

12 files changed

+125
-114
lines changed

12 files changed

+125
-114
lines changed

.eslintrc.js

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,19 @@ module.exports = {
1111
// override/add rules settings here, such as:
1212
// 'vue/no-unused-vars': 'error'
1313
},
14+
// true -> writable global variables
15+
// false -> readable global variables
16+
globals: {
17+
lightMode: true,
18+
Array: true,
19+
restrictedElements: true,
20+
globalScope: true,
21+
projectId: true,
22+
id: true,
23+
loading: true,
24+
embed: true,
25+
width: true,
26+
height: true,
27+
DPR: true,
28+
},
1429
}

src/components/ContextMenu/ContextMenu.vue

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
<div id="contextMenu" oncontextmenu="return false;">
33
<ul>
44
<li
5-
:key="index"
65
v-for="(menuOption, index) in contextMenuOptions"
6+
:key="index"
77
:data-index="index"
88
@click="menuItemClicked($event)"
99
>
@@ -41,6 +41,11 @@ export default {
4141
},
4242
}
4343
},
44+
45+
// Lifecycle hook on mounted - dont initially display the context menu
46+
mounted() {
47+
this.hideContextMenu()
48+
},
4449
methods: {
4550
hideContextMenu() {
4651
var el = document.getElementById('contextMenu')
@@ -75,11 +80,6 @@ export default {
7580
}
7681
},
7782
},
78-
79-
// Lifecycle hook on mounted - dont initially display the context menu
80-
mounted() {
81-
this.hideContextMenu()
82-
},
8383
}
8484
</script>
8585

src/components/Dropdown/DropDown.vue

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
11
<template>
22
<ul class="dropdown-menu">
3-
<li :key="listItem.id" v-for="listItem in listItems">
3+
<li v-for="listItem in listItems" :key="listItem.id">
44
<a
5+
:id="listItem.itemid"
56
class="dropdown-item"
67
:class="
78
dropDownType == 'navLink'
89
? 'logixButton text-left pl-1'
910
: ''
1011
"
11-
:id="listItem.itemid"
1212
style="white-space: pre-line"
1313
>{{ listItem.item }}
1414
</a>
1515
</li>
16-
<div class="dropdown-divider" v-if="dropDownType == 'user'"></div>
16+
<div v-if="dropDownType == 'user'" class="dropdown-divider"></div>
1717
<li v-if="dropDownType == 'user'">
1818
<a class="dropdown-item" rel="nofollow" data-method="delete"
1919
>Sign Out</a

0 commit comments

Comments
 (0)