-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new module to manage Virtual Port Channel Interfaces in Fabric Resource Policies Template. (DCNE-53) #551
Open
gmicol
wants to merge
5
commits into
CiscoDevNet:master
Choose a base branch
from
gmicol:mso_vpc_interface
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmicol
added
enhancement
New feature or request
jira-sync
Sync this issue to Jira
labels
Oct 11, 2024
gmicol
force-pushed
the
mso_vpc_interface
branch
from
October 28, 2024 17:20
4f77f85
to
d5cfb35
Compare
gmicol
requested review from
lhercot,
shrsr,
akinross,
anvitha-jain,
sajagana and
samiib
October 28, 2024 17:23
gmicol
force-pushed
the
mso_vpc_interface
branch
from
October 29, 2024 00:14
d5cfb35
to
bca2eee
Compare
akinross
requested changes
Oct 29, 2024
akinross
reviewed
Oct 29, 2024
akinross
requested changes
Oct 30, 2024
akinross
reviewed
Oct 30, 2024
akinross
previously approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
shrsr
requested changes
Oct 31, 2024
gmicol
force-pushed
the
mso_vpc_interface
branch
2 times, most recently
from
November 1, 2024 17:03
ad06fce
to
e953212
Compare
gmicol
force-pushed
the
mso_vpc_interface
branch
from
November 1, 2024 17:48
e953212
to
0e6144b
Compare
akinross
previously approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
samiib
requested changes
Nov 8, 2024
tests/integration/targets/ndo_virtual_port_channel_interface/tasks/main.yml
Show resolved
Hide resolved
…r possible empty strings attributes.
…riptions for payload data.
…t_channel_interfaces.
gmicol
force-pushed
the
mso_vpc_interface
branch
from
November 8, 2024 18:33
0e6144b
to
7a75f97
Compare
shrsr
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #467
New Modules Added: