Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new module to manage Virtual Port Channel Interfaces in Fabric Resource Policies Template. (DCNE-53) #551

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

gmicol
Copy link
Collaborator

@gmicol gmicol commented Oct 11, 2024

resolves #467

New Modules Added:

  • ndo_virtual_port_channel_interface

@gmicol gmicol added enhancement New feature or request jira-sync Sync this issue to Jira labels Oct 11, 2024
@gmicol gmicol self-assigned this Oct 11, 2024
plugins/modules/ndo_virtual_port_channel_interface.py Outdated Show resolved Hide resolved
plugins/modules/ndo_virtual_port_channel_interface.py Outdated Show resolved Hide resolved
plugins/modules/ndo_virtual_port_channel_interface.py Outdated Show resolved Hide resolved
plugins/modules/ndo_virtual_port_channel_interface.py Outdated Show resolved Hide resolved
plugins/modules/ndo_virtual_port_channel_interface.py Outdated Show resolved Hide resolved
@gmicol gmicol requested a review from akinross October 29, 2024 17:27
@gmicol gmicol requested a review from akinross October 30, 2024 18:02
akinross
akinross previously approved these changes Oct 31, 2024
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

plugins/modules/ndo_virtual_port_channel_interface.py Outdated Show resolved Hide resolved
plugins/modules/ndo_virtual_port_channel_interface.py Outdated Show resolved Hide resolved
plugins/modules/ndo_virtual_port_channel_interface.py Outdated Show resolved Hide resolved
plugins/modules/ndo_virtual_port_channel_interface.py Outdated Show resolved Hide resolved
akinross
akinross previously approved these changes Nov 5, 2024
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samiib samiib added has_PR and removed has_PR labels Nov 8, 2024
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request jira-sync Sync this issue to Jira
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: New module for Virtual Port Channel Interface in Fabric Resource Policies Template (DCNE-53)
4 participants