Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update query on uuid, on all the existing NDO modules (DCNE-184) #537

Open
anvitha-jain opened this issue Sep 19, 2024 · 1 comment
Open
Labels
enhancement New feature or request jira-sync Sync this issue to Jira

Comments

@anvitha-jain
Copy link
Collaborator

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

  • As query now possible on uuid, wich is changed on the new module ndo_mac_sec_policy ( ND v3.1 (NDO v4.3)), similar changes will be done in the below listed existing NDO modules.

Affected Module Name(s):

  • ndo_dhcp_option_policy,
  • ndo_dhcp_relay_policy,
  • ndo_l3_domain,
  • ndo_physical_domain,
  • ndo_route_map_policy_multicast,
  • ndo_synce_interface_policy,
  • ndo_vlan_pool.

MSO version and MSO Platform

  • V x.x.x and Docker Swarm OVA-based/SE-based/ND-based/all.

APIC version and APIC Platform for Site Level Resources

  • V x.x.x and on-prem/cloud-aws/cloud-azure/all.

Collection versions

  • cisco.mso x.x.x

Output/ Error message

Expected Behavior

Actual Behavior

Playbook tasks to Reproduce

Important Factoids

References

  • #0000
@anvitha-jain anvitha-jain added bug Something isn't working jira-sync Sync this issue to Jira labels Sep 19, 2024
@github-actions github-actions bot changed the title Update query on uuid, on all the existing NDO modules Update query on uuid, on all the existing NDO modules (DCNE-184) Sep 19, 2024
@akinross
Copy link
Collaborator

Should we update this issue to not limit the scope to query only, but then also support present/absent scenarios.

I think if we change below only we can also support the update and delete scenarios. Should we add this to do full uuid support?

        required_if=[
            ["state", "present", ["a", "a_uuid"], True],
            ["state", "absent", ["a", "a_uuid"], True],
if a or a_uuid:
     -  ....lookup_logic

I think with this logic you should be able to do the lookup properly and then the create/delete can be done or the change of attributes can all stay the same once there is a match. We would then only need to decide and double check that we always error when UUID is not found for present scenario.

@akinross akinross added enhancement New feature or request and removed bug Something isn't working labels Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request jira-sync Sync this issue to Jira
Projects
None yet
Development

No branches or pull requests

2 participants