Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1303 doc updates for read only (DCNE-258) #1317

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

1303 doc updates for read only (DCNE-258) #1317

wants to merge 17 commits into from
+3,910 −1,666

Conversation

akinross
Copy link
Collaborator

fixes #1303

requires rebase after merge of #1307, only review commit: 6e2bf76 - (HEAD -> 1303_doc_updates_for_read_only, origin/1303_doc_updates_for_read_only) [ignore] fix read-only attributes to be set in the read-only section of resource documentation

akinross added 17 commits January 26, 2025 12:25
@akinross
[ignore] fix plan does not detect read-only attributes changed when n…
dae84c9 
…othing else is changed in plan
@akinross
[ignore] add support for null to plan when state is null and plan unk…
61705c6 
…nown attributes inside of sets
@akinross
[ignore] fix test dependencies for templates with legacy attributes, …
a8cc8aa 
…and add support for reference attributes of dependencies in tests
@akinross
[ignore] change modify plan to never set legacy attributes
95ff302
@akinross
[ignore] fix plan modification to only set to unknown when not provid…
559ad71 
…ed in config
@akinross
[ignore] fix annotation in children from legacy attribute input
85a0dcc
@akinross
[ignore] fix annotation in children from legacy attribute input
bdc7a72
@akinross
[ignore] remove update to null when set is unknown
cf031b4
@akinross
[ignore] remove logic for deprecated attribute relation_fv_rs_path_att
a082133
@akinross
[ignore] add code commet for the SetToSetNullWhenStateIsNullPlanIsUnk…
c0cd67d 
…nownDuringUpdate functions
@akinross
[ignore] add legacy testvars with dependecies for all legacy attributes
9d2014e
@akinross
[ignore] add test configuration for legacy attributes
ca5a708
@akinross
[ignore] fix setting of singlenested attributes to null in plan modif…
77eb159 
…y when the object is existing
@akinross
[ignore] add test for legacy attributes to resource tests
ed697f2
@akinross
[ignore] deprecate relation_fv_rs_bd_to_profile because the configura…
c3084aa 
…tion requires more input in order to resolve the tDn
@akinross
[ignore] add test case for creation of bd/epg/esg with legacy attributes
31c4cd5
@akinross
[ignore] fix read-only attributes to be set in the read-only section …
6e2bf76 
…of resource documentation
@github-actions github-actions bot changed the title 1303 doc updates for read only 1303 doc updates for read only (DCNE-258) Mar 11, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 67.63881% with 577 lines in your changes missing coverage. Please review.

Project coverage is 86.81%. Comparing base (5dff413) to head (6e2bf76).

Files with missing lines Patch % Lines
internal/provider/resource_aci_application_epg.go 63.34% 200 Missing and 61 partials ⚠️
internal/provider/resource_aci_bridge_domain.go 75.83% 98 Missing and 11 partials ⚠️
...l/provider/resource_aci_endpoint_security_group.go 78.87% 54 Missing and 21 partials ⚠️
...nternal/provider/resource_aci_custom_qos_policy.go 30.76% 54 Missing and 18 partials ⚠️
...rnal/provider/resource_aci_l3out_consumer_label.go 61.53% 15 Missing and 5 partials ⚠️
.../provider/resource_aci_vrf_fallback_route_group.go 44.44% 15 Missing and 5 partials ⚠️
...ci_external_management_network_instance_profile.go 57.14% 9 Missing and 3 partials ⚠️
...al/provider/resource_aci_netflow_monitor_policy.go 66.66% 6 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1317      +/-   ##
==========================================
+ Coverage   85.70%   86.81%   +1.10%     
==========================================
  Files         129      129              
  Lines       73582    74394     +812     
==========================================
+ Hits        63067    64588    +1521     
+ Misses       8500     7800     -700     
+ Partials     2015     2006       -9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

shrsr
shrsr approved these changes Mar 11, 2025
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmicol
gmicol approved these changes Mar 11, 2025
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrsr shrsr shrsr approved these changes

@gmicol gmicol gmicol approved these changes

@anvitha-jain anvitha-jain Awaiting requested review from anvitha-jain anvitha-jain is a code owner

@lhercot lhercot Awaiting requested review from lhercot lhercot is a code owner

@sajagana sajagana Awaiting requested review from sajagana sajagana is a code owner

@samiib samiib Awaiting requested review from samiib samiib is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Read-Only attributes in resources are displayed in optional section instead of under read-only (DCNE-258)
4 participants
@akinross @codecov-commenter @shrsr @gmicol