Skip to content
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.

Improving Transaction History Struct #1

Open
saltyskip opened this issue Sep 20, 2017 · 0 comments
Open

Improving Transaction History Struct #1

saltyskip opened this issue Sep 20, 2017 · 0 comments

Comments

@saltyskip
Copy link

saltyskip commented Sep 20, 2017

Problem: Currently the transaction history struct is not well defined.

  • Each entry can represent either a gas or neo transaction (Ok if we only have neo or gas, but bad if we have more assets)
  • No timestamp, although block index is a useful trait most wallets would likely prefer to have a human readable date for transaction time
  • No Transaction type (Differentiating between claim and send)
  • No attached addresses

Without these data fields I have to manually query for each transaction again using an RPC command to get additional details

Solution: Remodel each entry in the struct to look like this

{ transactionHistory: [
	entry : {
		blockIndex: Int
		timestamp: Int
		transactionType: String
		assetID: String
		amount: Double
		senderAddress: String
		recieverAddress: String
		transactionID: String
	}]	
}

This allows for a more detailed history, and will be easier to use in light clients. Also I'm wondering how this will work once RPX token is introduced

slipo pushed a commit to slipo/neon-wallet-db that referenced this issue Jan 18, 2018
Syncing code updates to work without lastTrustedBlock preset
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant