Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result-variables aren't set as per the FindBoost module? #7

Open
CraigHutchinson opened this issue Mar 2, 2023 · 3 comments
Open

Comments

@CraigHutchinson
Copy link

CraigHutchinson commented Mar 2, 2023

I can't drop in boost-cmake in place of an existing project that uses Legacy-cmake variables such as Boost_INCLUDE_DIRS. May be a separate build issue but I couldn't see these defined here somehow?

The list of expected one are documented on the FindBoost module:
https://cmake.org/cmake/help/latest/module/FindBoost.html#result-variables

@CraigHutchinson
Copy link
Author

A far from complete solution but I have managed a workaround in the client code:

# Support pre Cmake 3.x Target based dependency mode
 set(Boost_BOOST_LIBRARY Boost::boost)
 set(Boost_PYTHON_LIBRARY Boost::python)
 set(Boost_INCLUDE_DIRS $<TARGET_PROPERTY:Boost::headers,INTERFACE_INCLUDE_DIRECTORIES>)

@bilke
Copy link

bilke commented Jan 21, 2025

@CraigHutchinson Have you adapted this module to support Boost::python as well? If you yes would you share it? That would be awesome!

@CraigHutchinson
Copy link
Author

@CraigHutchinson Have you adapted this module to support Boost::python as well? If you yes would you share it? That would be awesome!

Hi, sorry, I can't recall what I working in here 2 years ago and have unfortunately not been working in cmake world since. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants