Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cc-logs: add a breakpoint mode on the filter #1175

Open
pdesoyres-cc opened this issue Oct 4, 2024 · 0 comments
Open

cc-logs: add a breakpoint mode on the filter #1175

pdesoyres-cc opened this issue Oct 4, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@pdesoyres-cc
Copy link
Contributor

pdesoyres-cc commented Oct 4, 2024

Context

  • you search for a specific log but you don't know when it occurred
  • you go to the last 7 days view
  • you type the thing you're looking for in the filter input
  • and you see that logs are loading, but with the filter, nothing is displayed on the log panel
  • after a certain amount of time, you can see a log matching the filter... hurray!
  • but the logs are still loading
  • after a certain amount of time, you see your matching log disappear because of the hard limit that the component can handle.

This happens because the filter is handled on client side.

Idea

We could have a mode where the log stream is paused every time a log matches the filter.

We could add a toggle button somewhere close to the filter input that when activated, works a little bit like a breakpoint.

Alternatives

We could play the filter on server side, but there will be some annoying side effects like:

  • the stream would be replayed from the beginning every time the filter is changed
  • the filtering would not be as fast as now (in memory filtering is fast)
@pdesoyres-cc pdesoyres-cc added the enhancement New feature or request label Oct 4, 2024
@pdesoyres-cc pdesoyres-cc added this to the logs milestone Oct 4, 2024
@pdesoyres-cc pdesoyres-cc changed the title Add a breakpoint mode on the filter cc-logs: add a breakpoint mode on the filter Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant