feat(cc-order-summary): improve configuration item implementation #1347
+56
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1346 Make skeleton state more customisable. Add `aria-live` property.
|
🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/cc-order-summary/improve-configuration-item/index.html. This preview will be deleted once this PR is closed. |
roberttran-cc
requested review from
florian-sanders-cc,
hsablonniere,
Galimede,
pdesoyres-cc and
clara-layus-cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1346
What does this PR do?
For each line of the "configuration" part (aka the main part):
skeletonpropertyariaLivepropertyHow to review?
Two should be enough, with a mandatory one from @florian-sanders-cc. 🫰
Thoughts
At some point, I considered making skeleton state on label & value separately but I'm not sure if it's worth the complexity. Maybe later if really needed.