Challenge: overrun. Unable to generate a valid starting location

[Kurogami47]

Describe the bug

Game refuses to generate a starting location when playing the overrun challenge at the military base.

Attach save file

N/A

Steps to reproduce

1. Create a world like normal and load into it, mods don't matter as I've tried loading in without any mods selected.
2. Create your character and proceed.

Expected behavior

Game fails to generate a starting location. I've tried multiple times with multiple different world and it still fails to generate a starting location.

Screenshots

No response

Versions and configuration

• Android
• Experimental 2025-01-09-2011 5e1277a
• Chibi_Ultica
• English

Additional context

No response

[PatrikLundell]

/Confirmed

I hope it's permitted to confirm the issue based on the fact that the location mentioned in the posted error message exists only in conjunction with the scenario information, but not as any terrain in the JSON files.

I guess some rework quite a while ago changed the terrain designations without it being realized it was used for a starting scenario.

[Procyonae]

I hope it's permitted to confirm the issue based on the fact that the location mentioned in the posted error message exists only in conjunction with the scenario information, but not as any terrain in the JSON files.
I guess some rework quite a while ago changed the terrain designations without it being realized it was used for a starting scenario.

It's a valid start location that targets a valid omt that spawns and none of the ids have changed remotely recently wdym?
https://github.com/CleverRaven/Cataclysm-DDA/blame/25adee5b8a9b4cec0785d33fac523d73fa951b32/data/json/start_locations.json#L674-L679
https://github.com/CleverRaven/Cataclysm-DDA/blame/25adee5b8a9b4cec0785d33fac523d73fa951b32/data/json/mapgen/military/mil_base/mil_base_z0.json#L312-L390

Cataclysm-DDA/data/json/overmap/overmap_special/specials.json

Line 5803 in 25adee5

{ "point": [ 1, 6, 0 ], "overmap": "mil_base_2g_north" },

I also just spawned in fine 3 tries out of 3

[PatrikLundell]

Sorry, it seems I did indeed screw up!

I guess it needs to be set back to "S1 - Need confirmation".

Thus, it seems the issue is that the base wasn't generated nearby, and the follow on question to the author of this report is what parameters were used to generate the world, as I guess some parameters may make the placement of some things impossible or low probability.

[Procyonae]

Ye it could be that, you can just get these randomly tho it's all rng after all. I've tried rigging up boosting the priority of the chosen start location omt during initial gen but with how everything is scoped + included it's pretty awkward https://github.com/CleverRaven/Cataclysm-DDA/compare/master...Procyonae:BoostStartLocationPriority?expand=1
If scoping wasn't an issue it'd be pretty easy to override occurrences too and stop overriding them once 1 has been placed.

[PatrikLundell]

Couldn't you use g as a storage place for whether you've placed your boosted location already?

Basically set "boost_location" to false default, set it to true when setting up the priority boost stuff, reset it when placing that location, and add it as a condition in is_boosted_special?

You might be able to do it using only boosted_specials_start_loc by the delaying clearing of it, but that may complicate things more than it's worth.

[Procyonae]

Game includes start location and overmapbuffer includes game so I think it has to be this way around unless I just slap circular includes on them and hope it "just works". I can make what I have work I just need to move the start locations priorities out of the member bc the member is const when accessed through it's id

[Kurogami47]

Sorry for the late reply, I tried reinstalling the game yesterday and it's worked perfectly. No idea what the issue was but I'm guessing when I updated the game the install didn't go smoothly.