Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When moving an item to a container using the advanced item management menu, only try to put the item into that container and not into a sub-container of that container. #79833

Open
typeryougishiki opened this issue Feb 24, 2025 · 4 comments
Labels
<Suggestion / Discussion> Talk it out before implementing

Comments

@typeryougishiki
Copy link
Contributor

typeryougishiki commented Feb 24, 2025

Is your feature request related to a problem? Please describe.

When I transfer a nail to a container with space in the advanced item management menu, the game sometimes places the nail in a sub-container with space within that container (even a sealed container), which is very annoying.

Solution you would like.

When moving an item to a container using the advanced item management menu, only try to put the item into that container and not into a sub-container of that container.

Describe alternatives you have considered.

At the very least, don't allow items to be placed in sealed containers without the player realizing it when picking them up or transferring them.

Additional context

No response

@typeryougishiki typeryougishiki added the <Suggestion / Discussion> Talk it out before implementing label Feb 24, 2025
@moxian
Copy link
Contributor

moxian commented Feb 24, 2025

the game sometimes places the nail in a sub-container with space

This is a known bug, but it's been very tricky to nail (ha!) down due to this behaviour only happening sometimes and not remotely consistently.

If you can share a save file and instructions that reproduce the issue - that would be very helpful

@typeryougishiki
Copy link
Contributor Author

typeryougishiki commented Feb 24, 2025

the game sometimes places the nail in a sub-container with space

This is a known bug, but it's been very tricky to nail (ha!) down due to this behaviour only happening sometimes and not remotely consistently.

If you can share a save file and instructions that reproduce the issue - that would be very helpful

Try three times, move a mile into oversize cardboard box in warped hauler's harness, all move into seal nedium tin can.
布兰丁.zip

Image

@typeryougishiki
Copy link
Contributor Author

typeryougishiki commented Feb 27, 2025

This is probably caused by Advanced Item Management moving items indirectly using item::fill_with(allow_sealed=true,unseal=true) when moving the charge item. This causes it to look for pockets in the container contents as the destination and use the sealed pockets I might be able to try to fix this.

@Zireael07
Copy link
Contributor

"might be able to fix" isn't a reason to mark issue as complete afaik. Issues are closed once they're actually fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Suggestion / Discussion> Talk it out before implementing
Projects
None yet
Development

No branches or pull requests

3 participants