Use 2018 edition

Author: Seulgi Kim

Cargo.toml

@@ -12,6 +12,7 @@ exclude = [
     "spec/*",
     "test/*",
 ]
+edition = "2018"
 
 [dependencies]
 app_dirs = "^1.2.1"

core/Cargo.toml

@@ -2,6 +2,7 @@
 name = "codechain-core"
 version = "0.1.0"
 authors = ["CodeChain Team <[email protected]>"]
+edition = "2018"
 
 [dependencies]
 codechain-crypto = { git = "https://github.com/CodeChain-io/rust-codechain-crypto.git", version = "0.1" }

core/src/client/client.rs

@@ -92,7 +92,7 @@ impl Client {
         message_channel: IoChannel<ClientIoMessage>,
         reseal_timer: TimerApi,
     ) -> Result<Arc<Client>, Error> {
-        let journal_db = journaldb::new(Arc::clone(&db), journaldb::Algorithm::Archive, ::db::COL_STATE);
+        let journal_db = journaldb::new(Arc::clone(&db), journaldb::Algorithm::Archive, crate::db::COL_STATE);
         let mut state_db = StateDB::new(journal_db);
         if !scheme.check_genesis_root(state_db.as_hashdb()) {
             return Err(SchemeError::InvalidState.into())
@@ -607,7 +607,7 @@ impl BlockChainTrait for Client {
         self.genesis_accounts.iter().map(|addr| PlatformAddress::new_v1(network_id, *addr)).collect()
     }
 
-    fn block_header(&self, id: &BlockId) -> Option<::encoded::Header> {
+    fn block_header(&self, id: &BlockId) -> Option<encoded::Header> {
         let chain = self.block_chain();
 
         Self::block_hash(&chain, id).and_then(|hash| chain.block_header_data(&hash))
@@ -635,7 +635,7 @@ impl BlockChainTrait for Client {
         self.transaction_address(id).map(|addr| addr.block_hash)
     }
 
-    fn transaction_header(&self, tracker: &Tracker) -> Option<::encoded::Header> {
+    fn transaction_header(&self, tracker: &Tracker) -> Option<encoded::Header> {
         self.transaction_addresses(tracker).map(|addr| addr.block_hash).and_then(|hash| self.block_header(&hash.into()))
     }
 }
@@ -655,7 +655,7 @@ impl ImportBlock for Client {
     }
 
     fn import_header(&self, bytes: Bytes) -> Result<BlockHash, BlockImportError> {
-        let unverified = ::encoded::Header::new(bytes).decode();
+        let unverified = encoded::Header::new(bytes).decode();
         {
             if self.block_chain().is_known_header(&unverified.hash()) {
                 return Err(BlockImportError::Import(ImportError::AlreadyInChain))

core/src/client/importer.rs

@@ -29,6 +29,7 @@ use rlp::Encodable;
 use super::{BlockChainTrait, Client, ClientConfig};
 use crate::block::{enact, IsBlock, LockedBlock};
 use crate::blockchain::{BodyProvider, HeaderProvider, ImportRoute};
+use crate::client::EngineInfo;
 use crate::consensus::CodeChainEngine;
 use crate::error::Error;
 use crate::miner::{Miner, MinerService};
@@ -37,7 +38,6 @@ use crate::types::BlockId;
 use crate::verification::queue::{BlockQueue, HeaderQueue};
 use crate::verification::{self, PreverifiedBlock, Verifier};
 use crate::views::{BlockView, HeaderView};
-use client::EngineInfo;
 
 pub struct Importer {
     /// Lock used during block import

core/src/client/mod.rs

@@ -75,7 +75,7 @@ pub trait BlockChainTrait {
     /// Get the hash of block that contains the transaction, if any.
     fn transaction_block(&self, id: &TransactionId) -> Option<BlockHash>;
 
-    fn transaction_header(&self, tracker: &Tracker) -> Option<::encoded::Header>;
+    fn transaction_header(&self, tracker: &Tracker) -> Option<encoded::Header>;
 
     fn transaction_block_number(&self, tracker: &Tracker) -> Option<BlockNumber> {
         self.transaction_header(tracker).map(|header| header.number())

core/src/client/test_client.rs

@@ -54,10 +54,9 @@ use rlp::*;
 
 use crate::block::{ClosedBlock, OpenBlock, SealedBlock};
 use crate::blockchain_info::BlockChainInfo;
-use crate::client::ImportResult;
 use crate::client::{
-    AccountData, BlockChainClient, BlockChainTrait, BlockProducer, BlockStatus, EngineInfo, ImportBlock,
-    MiningBlockChainClient, StateInfo, StateOrBlock, TermInfo,
+    AccountData, BlockChainClient, BlockChainTrait, BlockProducer, BlockStatus, ConsensusClient, EngineInfo,
+    ImportBlock, ImportResult, MiningBlockChainClient, StateInfo, StateOrBlock, TermInfo,
 };
 use crate::consensus::stake::{Validator, Validators};
 use crate::consensus::EngineError;
@@ -68,7 +67,6 @@ use crate::miner::{Miner, MinerService, TransactionImportResult};
 use crate::scheme::Scheme;
 use crate::transaction::{LocalizedTransaction, PendingSignedTransactions, SignedTransaction};
 use crate::types::{BlockId, TransactionId, VerificationQueueInfo as QueueInfo};
-use client::ConsensusClient;
 
 /// Test client.
 pub struct TestBlockChainClient {
@@ -459,7 +457,7 @@ impl BlockChainTrait for TestBlockChainClient {
         None // Simple default.
     }
 
-    fn transaction_header(&self, _tracker: &Tracker) -> Option<::encoded::Header> {
+    fn transaction_header(&self, _tracker: &Tracker) -> Option<encoded::Header> {
         None
     }
 }

core/src/consensus/mod.rs

@@ -56,7 +56,7 @@ use crate::codechain_machine::CodeChainMachine;
 use crate::error::Error;
 use crate::transaction::UnverifiedTransaction;
 use crate::views::HeaderView;
-use Client;
+use crate::Client;
 
 pub enum Seal {
     Solo,

core/src/consensus/stake/actions.rs

@@ -18,12 +18,12 @@ use std::sync::Arc;
 
 use ccrypto::Blake;
 use ckey::{recover, Address, Signature};
-use client::ConsensusClient;
 use ctypes::errors::SyntaxError;
 use ctypes::CommonParams;
 use primitives::{Bytes, H256};
 use rlp::{Decodable, DecoderError, Encodable, Rlp, RlpStream};
 
+use crate::client::ConsensusClient;
 use crate::consensus::{ConsensusMessage, ValidatorSet};
 
 const ACTION_TAG_TRANSFER_CCS: u8 = 1;
@@ -358,9 +358,9 @@ impl Decodable for Action {
 #[cfg(test)]
 mod tests {
     use super::*;
+    use crate::client::TestBlockChainClient;
+    use crate::consensus::{ConsensusMessage, DynamicValidator, Step, VoteOn, VoteStep};
     use ckey::sign_schnorr;
-    use client::TestBlockChainClient;
-    use consensus::{ConsensusMessage, DynamicValidator, Step, VoteOn, VoteStep};
     use ctypes::BlockHash;
     use rlp::rlp_encode_and_decode_test;
 

core/src/consensus/stake/mod.rs

@@ -547,7 +547,7 @@ mod tests {
     use super::action_data::get_account_key;
     use super::*;
 
-    use consensus::stake::action_data::{get_delegation_key, Candidate, Prisoner};
+    use crate::consensus::stake::action_data::{get_delegation_key, Candidate, Prisoner};
     use cstate::tests::helpers;
     use cstate::TopStateView;
     use rlp::Encodable;

core/src/consensus/tendermint/mod.rs

@@ -41,7 +41,7 @@ pub use self::types::{Height, Step, View};
 use super::{stake, ValidatorSet};
 use crate::client::ConsensusClient;
 use crate::codechain_machine::CodeChainMachine;
-use ChainNotify;
+use crate::ChainNotify;
 
 /// Timer token representing the consensus step timeouts.
 const ENGINE_TIMEOUT_TOKEN_NONCE_BASE: TimerToken = 23;

core/src/consensus/tendermint/vote_regression_checker.rs

@@ -1,6 +1,7 @@
-use consensus::{Step, VoteOn};
 use std::cmp::Ordering;
 
+use crate::consensus::{Step, VoteOn};
+
 pub struct VoteRegressionChecker {
     last_vote: Option<VoteOn>,
 }
@@ -41,7 +42,9 @@ impl VoteRegressionChecker {
 #[cfg(test)]
 mod tests {
     use super::*;
-    use consensus::VoteStep;
+
+    use crate::consensus::VoteStep;
+
     use primitives::H256;
 
     #[test]

core/src/consensus/validator_set/dynamic_validator.rs

@@ -199,8 +199,7 @@ mod tests {
 
     use super::super::ValidatorSet;
     use super::DynamicValidator;
-    use crate::client::TestBlockChainClient;
-    use client::ConsensusClient;
+    use crate::client::{ConsensusClient, TestBlockChainClient};
 
     #[test]
     fn validator_set() {

core/src/miner/mod.rs

@@ -86,7 +86,7 @@ pub trait MinerService: Send + Sync {
     fn engine_type(&self) -> EngineType;
 
     /// Returns true if we had to prepare new pending block.
-    fn prepare_work_sealing<C>(&self, &C) -> bool
+    fn prepare_work_sealing<C>(&self, _: &C) -> bool
     where
         C: AccountData + BlockChainTrait + BlockProducer + ChainTimeInfo + EngineInfo + FindActionHandler + TermInfo;
 

core/src/verification/queue/kind.rs

@@ -93,7 +93,7 @@ pub mod headers {
     use crate::consensus::CodeChainEngine;
     use crate::error::Error;
     use crate::service::ClientIoMessage;
-    use verification::verify_header_with_engine;
+    use crate::verification::verify_header_with_engine;
 
     impl BlockLike for Header {
         fn hash(&self) -> BlockHash {

core/src/verification/queue/mod.rs

@@ -527,12 +527,12 @@ pub struct Verifying<K: Kind> {
 #[cfg(test)]
 mod tests {
     use cio::IoChannel;
-    use tests::helpers::*;
 
     use super::kind::blocks::Unverified;
     use super::{BlockQueue, Config};
     use crate::error::{Error, ImportError};
     use crate::scheme::Scheme;
+    use crate::tests::helpers::get_good_dummy_block;
 
     // create a test block queue.
     // auto_scaling enables verifier adjustment.

discovery/Cargo.toml

@@ -2,6 +2,7 @@
 name = "codechain-discovery"
 version = "0.1.0"
 authors = ["CodeChain Team <[email protected]>"]
+edition = "2018"
 
 [dependencies]
 codechain-crypto = { git = "https://github.com/CodeChain-io/rust-codechain-crypto.git", version = "0.1" }

json/Cargo.toml

@@ -2,6 +2,7 @@
 name = "codechain-json"
 version = "0.1.0"
 authors = ["CodeChain Team <[email protected]>"]
+edition = "2018"
 
 [dependencies]
 codechain-key = { path = "../key" }

key/Cargo.toml

@@ -2,6 +2,7 @@
 name = "codechain-key"
 version = "0.1.0"
 authors = ["debris <[email protected]>", "CodeChain Team <[email protected]>"]
+edition = "2018"
 
 [dependencies]
 rand = "0.6.1"

key/src/private.rs

@@ -18,10 +18,10 @@ use std::fmt;
 use std::ops::Deref;
 use std::str::FromStr;
 
-use hex::ToHex;
 use primitives::H256;
 use secp256k1::key;
 
+use crate::hex::ToHex;
 use crate::Error;
 
 #[derive(Clone, Copy, PartialEq, Eq)]

keystore/Cargo.toml

@@ -2,6 +2,7 @@
 name = "codechain-keystore"
 version = "0.1.0"
 authors = ["CodeChain Team <[email protected]>", "Parity Technologies <[email protected]>"]
+edition = "2018"
 
 [dependencies]
 log = "0.4.6"

keystore/src/account/safe_account.rs

@@ -19,8 +19,7 @@ use ckey::{Address, KeyPair, Password};
 
 use super::crypto::Crypto;
 use crate::account::Version;
-use crate::{json, Error};
-use DecryptedAccount;
+use crate::{json, DecryptedAccount, Error};
 
 /// Account representation.
 #[derive(Debug, PartialEq, Clone)]

keystore/src/accounts_dir/disk.rs

@@ -176,7 +176,7 @@ where
 
         // check for duplicate filename and append random suffix
         if dedup && keyfile_path.exists() {
-            let suffix = ::random::random_string(4);
+            let suffix = crate::random::random_string(4);
             filename.push_str(&format!("-{}", suffix));
             keyfile_path.set_file_name(&filename);
         }

network/Cargo.toml

@@ -2,6 +2,7 @@
 name = "codechain-network"
 version = "0.1.0"
 authors = ["CodeChain Team <[email protected]>"]
+edition = "2018"
 
 [dependencies]
 codechain-crypto = { git = "https://github.com/CodeChain-io/rust-codechain-crypto.git", version = "0.1" }

rpc/Cargo.toml

@@ -2,6 +2,7 @@
 name = "codechain-rpc"
 version = "0.1.0"
 authors = ["CodeChain Team <[email protected]>"]
+edition = "2018"
 
 [lib]
 

state/Cargo.toml

@@ -2,6 +2,7 @@
 name = "codechain-state"
 version = "0.1.0"
 authors = ["CodeChain Team <[email protected]>"]
+edition = "2018"
 
 [dependencies]
 codechain-crypto = { git = "https://github.com/CodeChain-io/rust-codechain-crypto.git", version = "0.1" }

stratum/Cargo.toml

@@ -4,6 +4,7 @@ name = "codechain-stratum"
 version = "1.11.0"
 license = "GPL-3.0"
 authors = ["Parity Technologies <[email protected]>", "CodeChain Team <[email protected]>"]
+edition = "2018"
 
 [dependencies]
 codechain-crypto = { git = "https://github.com/CodeChain-io/rust-codechain-crypto.git", version = "0.1" }

sync/Cargo.toml

@@ -2,6 +2,7 @@
 name = "codechain-sync"
 version = "0.1.0"
 authors = ["CodeChain Team <[email protected]>"]
+edition = "2018"
 
 [lib]
 

types/Cargo.toml

@@ -2,6 +2,7 @@
 name = "codechain-types"
 version = "0.1.0"
 authors = ["CodeChain Team <[email protected]>"]
+edition = "2018"
 
 [dependencies]
 codechain-crypto = { git = "https://github.com/CodeChain-io/rust-codechain-crypto.git", version = "0.1" }

util/error/Cargo.toml

@@ -2,6 +2,7 @@
 name = "util-error"
 version = "0.1.0"
 authors = ["Parity Technologies <[email protected]>"]
+edition = "2018"
 
 [dependencies]
 kvdb = { path = "../kvdb" }

util/hashdb/Cargo.toml

@@ -4,6 +4,7 @@ version = "0.1.1"
 authors = ["Parity Technologies <[email protected]>", "CodeChain Team <[email protected]>"]
 description = "trait for hash-keyed databases."
 license = "GPL-3.0"
+edition = "2018"
 
 [dependencies]
 primitives = { git = "https://github.com/CodeChain-io/rust-codechain-primitives.git", version = "0.4" }

util/io/Cargo.toml

@@ -5,6 +5,7 @@ license = "GPL-3.0"
 name = "codechain-io"
 version = "1.9.0"
 authors = ["Parity Technologies <[email protected]>", "CodeChain Team <[email protected]>"]
+edition = "2018"
 
 [dependencies]
 codechain-logger = { path = "../logger" }

util/io/src/service.rs

@@ -41,7 +41,8 @@ use mio::deprecated::{EventLoop, EventLoopBuilder, Handler, Sender};
 use mio::timer::Timeout;
 use mio::*;
 use parking_lot::{Mutex, RwLock};
-use worker::{Work, WorkType, Worker};
+
+use crate::worker::{Work, WorkType, Worker};
 
 use super::{IoError, IoHandler};
 

util/io/src/worker.rs

@@ -15,12 +15,13 @@
 // along with Parity.  If not, see <http://www.gnu.org/licenses/>.
 
 use crossbeam::deque;
-use service::{IoChannel, IoContext};
 use std::cell::Cell;
 use std::sync::atomic::{AtomicBool, Ordering as AtomicOrdering};
 use std::sync::Arc;
 use std::thread::{self, JoinHandle};
-use IoHandler;
+
+use crate::service::{IoChannel, IoContext};
+use crate::IoHandler;
 
 use std::sync::{Condvar as SCondvar, Mutex as SMutex};
 

util/journaldb/Cargo.toml

@@ -4,6 +4,7 @@ version = "0.1.0"
 authors = ["Parity Technologies <[email protected]>"]
 description = "A `HashDB` which can manage a short-term journal potentially containing many forks of mutually exclusive actions"
 license = "GPL3"
+edition = "2018"
 
 [dependencies]
 primitives = { git = "https://github.com/CodeChain-io/rust-codechain-primitives.git", version = "0.4" }