Upgrade rust toolchains

Author: Seulgi Kim

.github/workflows/cargo-test.yml

@@ -10,7 +10,7 @@ jobs:
       - uses: actions/checkout@v1
       - uses: actions-rs/toolchain@v1
         with:
-          toolchain: nightly-2019-10-13
+          toolchain: nightly-2019-11-06
           override: true
       - run: rustup component add clippy
       - run: cargo fetch --verbose
@@ -23,7 +23,7 @@ jobs:
       - uses: actions/checkout@v1
       - uses: actions-rs/toolchain@v1
         with:
-          toolchain: nightly-2019-10-13
+          toolchain: nightly-2019-11-06
           override: true
       - run: rustup component add rustfmt
       - run: cargo fmt -- --check

README.md

@@ -135,32 +135,32 @@ You can create a block by sending a transaction through [JSON-RPC](https://githu
 Make sure you run `rustfmt` before creating a PR to the repo. You need to install the nightly-2018-12-06 version of `rustfmt`.
 
 ```sh
-rustup toolchain install nightly-2019-10-13
-rustup component add rustfmt --toolchain nightly-2019-10-13
+rustup toolchain install nightly-2019-11-06
+rustup component add rustfmt --toolchain nightly-2019-11-06
 ```
 
 To run `rustfmt`,
 
 ```sh
-cargo +nightly-2019-10-13 fmt
+cargo +nightly-2019-11-06 fmt
 ```
 
 ## Linting
 
 You should run `clippy` also. This is a lint tool for rust. It suggests more efficient/readable code.
 You can see [the clippy document](https://rust-lang.github.io/rust-clippy/master/index.html) for more information.
-You need to install the nightly-2019-10-13 version of `clippy`.
+You need to install the nightly-2019-11-06 version of `clippy`.
 
 ### Install
 ```sh
-rustup toolchain install nightly-2019-10-13
-rustup component add clippy --toolchain nightly-2019-10-13
+rustup toolchain install nightly-2019-11-06
+rustup component add clippy --toolchain nightly-2019-11-06
 ```
 
 ### Run
 
 ```sh
-cargo +nightly-2019-10-13 clippy --all --all-targets
+cargo +nightly-2019-11-06 clippy --all --all-targets
 ```
 
 ## Testing

network/src/client.rs

@@ -230,7 +230,7 @@ impl Client {
 
     pub fn extension_versions(&self) -> Vec<(String, Vec<u64>)> {
         let extensions = self.extensions.read();
-        extensions.iter().map(|(name, extension)| (name.to_string(), extension.versions.clone())).collect()
+        extensions.iter().map(|(name, extension)| ((*name).to_string(), extension.versions.clone())).collect()
     }
 
     pub fn on_node_removed(&self, id: &NodeId) {

network/src/stream.rs

@@ -124,7 +124,7 @@ impl<Stream: TryRead + TryWrite + PeerAddr + Shutdown> TryStream<Stream> {
         Ok(None)
     }
 
-    fn read_len(&mut self) -> Result<Option<(Vec<u8>)>> {
+    fn read_len(&mut self) -> Result<Option<Vec<u8>>> {
         debug_assert_eq!(None, self.read);
         let mut bytes: Vec<u8> = vec![0];
 

rustfmt.toml

@@ -34,7 +34,6 @@ reorder_modules = true
 # reorder_impl_items = false
 # report_todo = "Never"
 # report_fixme = "Never"
-# skip_children = false
 space_after_colon = true
 space_before_colon = false
 struct_field_align_threshold = 0