Disable 'Export All Custom Themes' if custom themes is empty#2027
Merged
thecoolwinter merged 1 commit intoCodeEditApp:mainfrom Apr 16, 2025
Merged
Disable 'Export All Custom Themes' if custom themes is empty#2027thecoolwinter merged 1 commit intoCodeEditApp:mainfrom
thecoolwinter merged 1 commit intoCodeEditApp:mainfrom
Conversation
thecoolwinter
approved these changes
Apr 16, 2025
FastestMolasses
pushed a commit
that referenced
this pull request
May 12, 2025
### Description A quick PR... If the user doesn't have any custom themes, disable the "Export All Custom Themes...", as it still opens a save panel and lets the user choose a directory even though nothing's going to be saved. <!--- REQUIRED: Describe what changed in detail --> ### Checklist - [x] I read and understood the [contributing guide](https://github.com/CodeEditApp/CodeEdit/blob/main/CONTRIBUTING.md) as well as the [code of conduct](https://github.com/CodeEditApp/CodeEdit/blob/main/CODE_OF_CONDUCT.md) - [x] The issues this PR addresses are related to each other - [x] My changes generate no new warnings - [x] My code builds and runs on my machine - [x] My changes are all related to the related issue above - [ ] I documented my code ### Screenshots With no custom themes: <img width="929" alt="Screenshot 2025-04-14 at 17 54 45" src="https://github.com/user-attachments/assets/2cc76ac1-4980-4baa-9fbd-91f4197cd2e7" /> With custom themes: <img width="929" alt="Screenshot 2025-04-14 at 17 55 11" src="https://github.com/user-attachments/assets/c884e061-6909-4825-b4b1-903ccf56af4d" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A quick PR...
If the user doesn't have any custom themes, disable the "Export All Custom Themes...", as it still opens a save panel and lets the user choose a directory even though nothing's going to be saved.
Checklist
Screenshots
With no custom themes:
With custom themes:
