Skip to content

Add a PR template #347

Open
Open
@MadhavBahl

Description

@MadhavBahl
Member

Add the following check list in the PR template:

  • Created a folder with the name of language you code inside directory for the day you are making the contribution to
    Added your Codes
    Tested your codes
    Added credits (author and date) at the top of the code
    Updated README.md of the day you are contributing to
    Added yourself as a contributor using all-conributors-cli

Activity

SvA1

SvA1 commented on Oct 5, 2020

@SvA1
Contributor

Hi @MadhavBahlMD. I'd be glad to work on this. Can you assign me to the issue?

thelavenderhue

thelavenderhue commented on Oct 5, 2020

@thelavenderhue

Hey @MadhavBahlMD can I work on this?

yashasvimatta

yashasvimatta commented on Oct 5, 2020

@yashasvimatta

Hi @MadhavBahlMD this looks good. Could you assign me the issue?

Red-0111

Red-0111 commented on Oct 5, 2020

@Red-0111

Please assign @MadhavBahlMD I will try my best

MadhavBahl

MadhavBahl commented on Oct 5, 2020

@MadhavBahl
MemberAuthor

Hey guys,

Thanks a lot for your enthusiasm to contribute,

You all can feel free to take this issue and raise a PR,

Although I would recommend @SvA1 to take this up since he commented first,

but you all can feel free to discuss ideas here, and also take up lead on more ideas for this repository 🥳

SvA1

SvA1 commented on Oct 5, 2020

@SvA1
Contributor

Thanks!

yashasvimatta

yashasvimatta commented on Oct 7, 2020

@yashasvimatta

Hi @MadhavBahlMD i have created a pull request for fixing the issue , could you review it?

diogenesdauster

diogenesdauster commented on Oct 9, 2020

@diogenesdauster

I've made one PR for this issue, could you review it ? @MadhavBahlMD

MadhavBahl

MadhavBahl commented on Oct 14, 2020

@MadhavBahl
MemberAuthor

Hi @yashasvimatta and @diogenesdauster
Thanks a lot for your contributions 🥳
I will have a look at both your PRs on weekend

rajpratyush

rajpratyush commented on Oct 14, 2020

@rajpratyush

@MadhavBahlMD hi i am new to this github. i have made changes to the readme and the uploaded the code in the required directory but i am still having troubling to add my name into the contributors list. i did looked into the contributing guidelines but i am still unable to understand could you please guide me

removed their assignment
on Oct 22, 2020
elizabethqiu

elizabethqiu commented on Oct 25, 2020

@elizabethqiu

Hi @MadhavBahl ! can I work on this?

NormalVad

NormalVad commented on Oct 25, 2020

@NormalVad

Hi @MadhavBahl , I would like to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @diogenesdauster@MadhavBahl@SvA1@rajpratyush@elizabethqiu

    Issue actions

      Add a PR template · Issue #347 · CodeToExpress/dailycodebase