Skip to content

Commit ce582d0

Browse files
authored
fix(build): use SetVsixVersion parameter and standardize output paths (#29)
- Change -p:Version to -p:SetVsixVersion for correct VSIX versioning - Add OutputPath=bin/$(Configuration)/ to .csproj - Update artifact paths from bin/Release/net48/ to bin/Release/ - Rename build workflow from release_build_and_deploy.yml to build.yml - Update publish workflow to reference renamed build.yml
1 parent 25e1706 commit ce582d0

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

.github/workflows/release_build_and_deploy.yml renamed to .github/workflows/build.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,17 +35,17 @@ jobs:
3535
shell: pwsh
3636

3737
- name: 3. Building Project
38-
run: dotnet build src/CodingWithCalvin.OpenInNotepadPlusPlus/CodingWithCalvin.OpenInNotepadPlusPlus.csproj -c Release -p:Version=${{ steps.version.outputs.version }}
38+
run: dotnet build src/CodingWithCalvin.OpenInNotepadPlusPlus/CodingWithCalvin.OpenInNotepadPlusPlus.csproj -c Release -p:SetVsixVersion=${{ steps.version.outputs.version }}
3939

4040
- name: 4. Create Information File
4141
uses: jsdaniell/[email protected]
4242
with:
43-
name: 'src/CodingWithCalvin.OpenInNotepadPlusPlus/bin/Release/net48/CodingWithCalvin.OpenInNotepadPlusPlus.info'
43+
name: 'src/CodingWithCalvin.OpenInNotepadPlusPlus/bin/Release/CodingWithCalvin.OpenInNotepadPlusPlus.info'
4444
json: '{"sha":"${{ github.sha }}", "version":"${{ steps.version.outputs.version }}"}'
4545

4646
- name: 5. Publishing Build Artifact
4747
uses: actions/upload-artifact@v4
4848
with:
4949
path: |
50-
src/CodingWithCalvin.OpenInNotepadPlusPlus/bin/Release/net48/CodingWithCalvin.OpenInNotepadPlusPlus.info
51-
src/CodingWithCalvin.OpenInNotepadPlusPlus/bin/Release/net48/CodingWithCalvin.OpenInNotepadPlusPlus.vsix
50+
src/CodingWithCalvin.OpenInNotepadPlusPlus/bin/Release/CodingWithCalvin.OpenInNotepadPlusPlus.info
51+
src/CodingWithCalvin.OpenInNotepadPlusPlus/bin/Release/CodingWithCalvin.OpenInNotepadPlusPlus.vsix

.github/workflows/publish.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
id: download-artifact
2727
uses: dawidd6/action-download-artifact@v6
2828
with:
29-
workflow: release_build_and_deploy.yml
29+
workflow: build.yml
3030
workflow_conclusion: success
3131

3232
- name: 2. Parse Artifact Manifest

src/CodingWithCalvin.OpenInNotepadPlusPlus/CodingWithCalvin.OpenInNotepadPlusPlus.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
<RootNamespace>CodingWithCalvin.OpenInNotepadPlusPlus</RootNamespace>
66
<AssemblyName>CodingWithCalvin.OpenInNotepadPlusPlus</AssemblyName>
77
<LangVersion>latest</LangVersion>
8+
<OutputPath>bin/$(Configuration)/</OutputPath>
89
</PropertyGroup>
910

1011
<PropertyGroup Condition="'$(Configuration)' == 'Debug'">

0 commit comments

Comments
 (0)