-
Notifications
You must be signed in to change notification settings - Fork 2
CU-869ajt55f: Add option to use OIDC auth in medcat-trainer #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CU-869ajt55f: Add option to use OIDC auth in medcat-trainer #161
Conversation
- Add job in CI and QA workflows to test frontend
…https://github.com/CogStack/cogstack-nlp into CU-869admfwg-increase-test-coverage-in-medcattrainer
Create ConceptDatabase.spec.ts Fix indentation remove erroneously added test files readd new line at end of file
…https://github.com/CogStack/cogstack-nlp into CU-869admfwg-increase-test-coverage-in-medcattrainer
…els and gateway auth network
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only real change requested (I think) is missing using the env vars in medcat-trainer/webapp/api/core/settings.py, which hardcodes some urls. If that file doesnt need to use them, would put a comment in there
|
nice change! minor env var / docs changes and it's good to go I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…lised-IdP-with-feature-flag' into CU-869ajt55f_Add-auth-via-centralised-IdP-with-feature-flag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - feel free to merge in
* - Add tests to increase coverage in medcat-trainer frontend - Add job in CI and QA workflows to test frontend * Fix indentation * Update medcat-trainer_ci.yml * Fix line endings * properly fix line endings mismatch * Create ConceptDatabase.spec.ts * remove erroneously added test files * re-add end of file return * readd new line at end of file * properly fix line endings mismatch Create ConceptDatabase.spec.ts Fix indentation remove erroneously added test files readd new line at end of file * CU-869admfwg: Disable push to dockerhub in QA workflow for testing * CU-869admfwg: Remove workflow dispatch from QA workflow now that testing is complete * CU-869ajt55f: Initial dev setup with feature flag * CU-869ajt55f: Map Keycloak Roles to Django User * CU-869ajt55f: Add env var expansion to optionally include Traefik labels and gateway auth network * CU-869ajt55f: Tidy up configuration and fix logout * CU-869ajt55f: Disable OIDC auth by default * CU-869ajt55f: Revert unintended changes * CU-869ajt55f: Addressing code review feedback * CU-869ajt55f: Fix broken test
No description provided.