Skip to content

Conversation

@jocelyneholdbrook
Copy link
Contributor

No description provided.

- Add job in CI and QA workflows to test frontend
Create ConceptDatabase.spec.ts

Fix indentation

remove erroneously added test files

readd new line at end of file
@tomolopolis
Copy link
Member

Copy link
Collaborator

@alhendrickson alhendrickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only real change requested (I think) is missing using the env vars in medcat-trainer/webapp/api/core/settings.py, which hardcodes some urls. If that file doesnt need to use them, would put a comment in there

@tomolopolis
Copy link
Member

nice change! minor env var / docs changes and it's good to go I think

Copy link
Collaborator

@alhendrickson alhendrickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

…lised-IdP-with-feature-flag' into CU-869ajt55f_Add-auth-via-centralised-IdP-with-feature-flag
Copy link
Member

@tomolopolis tomolopolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - feel free to merge in

@jocelyneholdbrook jocelyneholdbrook merged commit 80831f5 into main Oct 8, 2025
9 checks passed
@jocelyneholdbrook jocelyneholdbrook deleted the CU-869ajt55f_Add-auth-via-centralised-IdP-with-feature-flag branch October 8, 2025 09:05
tomolopolis pushed a commit that referenced this pull request Oct 15, 2025
* - Add tests to increase coverage in medcat-trainer frontend
- Add job in CI and QA workflows to test frontend

* Fix indentation

* Update medcat-trainer_ci.yml

* Fix line endings

* properly fix line endings mismatch

* Create ConceptDatabase.spec.ts

* remove erroneously added test files

* re-add end of file return

* readd new line at end of file

* properly fix line endings mismatch

Create ConceptDatabase.spec.ts

Fix indentation

remove erroneously added test files

readd new line at end of file

* CU-869admfwg: Disable push to dockerhub in QA workflow for testing

* CU-869admfwg: Remove workflow dispatch from QA workflow now that testing is complete

* CU-869ajt55f: Initial dev setup with feature flag

* CU-869ajt55f: Map Keycloak Roles to Django User

* CU-869ajt55f: Add env var expansion to optionally include Traefik labels and gateway auth network

* CU-869ajt55f: Tidy up configuration and fix logout

* CU-869ajt55f: Disable OIDC auth by default

* CU-869ajt55f: Revert unintended changes

* CU-869ajt55f: Addressing code review feedback

* CU-869ajt55f: Fix broken test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants