CodeQA

Co-authored-by: Kemal Setya Adhi <[email protected]>

Author: bagusnl

ChunkSession.cs

@@ -41,7 +41,7 @@ internal static async IAsyncEnumerable<ChunkSession> EnumerateMultipleChunks(
             // Enumerate previous chunks inside the metadata first
             FileInfo outputFileInfo = new FileInfo(outputFilePath);
 
-            // If the overwrite is toggled and the file exist, delete them.
+            // If overwrite is toggled and the file exist, delete them.
             // Or if the file overflow, then delete the file and start from scratch
             if ((outputFileInfo.Exists && outputFileInfo.Length > contentLength)
               || outputFileInfo.Exists && overwrite)

DownloadClient.cs

@@ -1,11 +1,11 @@
 using System;
 using System.IO;
-using System.Linq;
 using System.Net;
 using System.Net.Http;
 using System.Threading;
 using System.Threading.Tasks;
 using System.Threading.Tasks.Dataflow;
+// ReSharper disable MemberCanBePrivate.Global
 
 // ReSharper disable AutoPropertyCanBeMadeGetOnly.Local
 // ReSharper disable UnusedMember.Global
@@ -325,7 +325,7 @@ await IO.WriteStreamToFileChunkSessionAsync(
         /// </summary>
         /// <param name="url">The URL to check</param>
         /// <param name="cancelToken">The cancellation token</param>
-        /// <returns>A tuple contains a <seealso cref="HttpResponseMessage.StatusCode"/> and a <seealso cref="bool"/> of the status code (true = success, false = failed)</returns>
+        /// <returns>A tuple contains a <seealso cref="HttpResponseMessage.StatusCode"/> and an <seealso cref="bool"/> of the status code (true = success, false = failed)</returns>
         public async ValueTask<(HttpStatusCode, bool)> GetURLStatus(string url, CancellationToken cancelToken)
             => await GetURLStatus(CurrentHttpClientInstance, url, cancelToken);
 
@@ -334,27 +334,27 @@ await IO.WriteStreamToFileChunkSessionAsync(
         /// </summary>
         /// <param name="url">The URL to check</param>
         /// <param name="cancelToken">The cancellation token</param>
-        /// <returns>A tuple contains a <seealso cref="HttpResponseMessage.StatusCode"/> and a <seealso cref="bool"/> of the status code (true = success, false = failed)</returns>
+        /// <returns>A tuple contains a <seealso cref="HttpResponseMessage.StatusCode"/> and an <seealso cref="bool"/> of the status code (true = success, false = failed)</returns>
         public async ValueTask<(HttpStatusCode, bool)> GetURLStatus(Uri url, CancellationToken cancelToken)
             => await GetURLStatus(CurrentHttpClientInstance, url, cancelToken);
 
         /// <summary>
-        /// Get the Http's <seealso cref="HttpResponseMessage.StatusCode"/> of the URL from a <seealso cref="HttpClient"/> instance.
+        /// Get the Http's <seealso cref="HttpResponseMessage.StatusCode"/> of the URL from an <seealso cref="HttpClient"/> instance.
         /// </summary>
         /// <param name="httpClient">The <seealso cref="HttpClient"/> instance to be used for URL checking</param>
         /// <param name="url">The URL to check</param>
         /// <param name="cancelToken">The cancellation token</param>
-        /// <returns>A tuple contains a <seealso cref="HttpResponseMessage.StatusCode"/> and a <seealso cref="bool"/> of the status code (true = success, false = failed)</returns>
+        /// <returns>A tuple contains a <seealso cref="HttpResponseMessage.StatusCode"/> and an <seealso cref="bool"/> of the status code (true = success, false = failed)</returns>
         public static async ValueTask<(HttpStatusCode, bool)> GetURLStatus(HttpClient httpClient, string url, CancellationToken cancelToken)
             => await GetURLStatus(httpClient, url.ToUri(), cancelToken);
 
         /// <summary>
-        /// Get the Http's <seealso cref="HttpResponseMessage.StatusCode"/> of the URL from a <seealso cref="HttpClient"/> instance.
+        /// Get the Http's <seealso cref="HttpResponseMessage.StatusCode"/> of the URL from an <seealso cref="HttpClient"/> instance.
         /// </summary>
         /// <param name="httpClient">The <seealso cref="HttpClient"/> instance to be used for URL checking</param>
         /// <param name="url">The URL to check</param>
         /// <param name="cancelToken">The cancellation token</param>
-        /// <returns>A tuple contains a <seealso cref="HttpResponseMessage.StatusCode"/> and a <seealso cref="bool"/> of the status code (true = success, false = failed)</returns>
+        /// <returns>A tuple contains a <seealso cref="HttpResponseMessage.StatusCode"/> and an <seealso cref="bool"/> of the status code (true = success, false = failed)</returns>
         public static async ValueTask<(HttpStatusCode, bool)> GetURLStatus(HttpClient httpClient, Uri url, CancellationToken cancelToken)
         {
             using (HttpResponseMessage response = await httpClient.SendAsync(
@@ -482,7 +482,7 @@ public static async ValueTask<long> GetDownloadedFileSize(
                 throw new InvalidOperationException($"You cannot set {nameof(httpClient)} to null while {nameof(expectedLength)} is set to 0!");
 
             // Get the file size from the URL or expected value
-            long contentLength = expectedLength > 0 ? expectedLength : await fileUrl.GetUrlContentLengthAsync(httpClient!, retryCountMax ?? DefaultRetryCountMax,
+            long contentLength = expectedLength > 0 ? expectedLength : await fileUrl.GetUrlContentLengthAsync(httpClient!, (int)retryCountMax,
                 retryAttemptInterval.Value, timeoutAfterInterval.Value, cancelToken);
 
             // Get the last session metadata info
@@ -504,9 +504,9 @@ public static async ValueTask<long> GetDownloadedFileSize(
             }
 
             // Enumerate last ranges
-            long lastEndOffset = currentSessionMetadata.Ranges.Count > 0
-                ? currentSessionMetadata.Ranges.Max(x => x?.End ?? 0) + 1
-                : 0;
+            // long lastEndOffset = currentSessionMetadata.Ranges.Count > 0
+            //     ? currentSessionMetadata.Ranges.Max(x => x?.End ?? 0) + 1
+            //     : 0;
 
             // If the metadata is not exist, but it has an uncompleted file with size > DefaultSessionChunkSize,
             // then try to resume the download and advance the lastEndOffset from the file last position.

DownloadSpeedLimiter.cs

@@ -1,4 +1,5 @@
 using System;
+// ReSharper disable UnusedType.Global
 
 namespace Hi3Helper.Http
 {
@@ -11,6 +12,7 @@ namespace Hi3Helper.Http
     public class DownloadSpeedLimiter
     {
         internal event EventHandler<long>? DownloadSpeedChangedEvent;
+        // ReSharper disable once MemberCanBePrivate.Global
         internal long? InitialRequestedSpeed { get; set; }
         private EventHandler<long>? InnerListener { get; set; }
 
@@ -30,8 +32,9 @@ public static DownloadSpeedLimiter CreateInstance(long initialSpeed)
         /// <summary>
         /// Get the listener for the parent event
         /// </summary>
-        /// <returns>The <seealso cref="EventHandler{long}"/> of the listener.</returns>
-        public EventHandler<long> GetListener() => InnerListener ??= new EventHandler<long>(DownloadSpeedChangeListener);
+        /// <returns>The EventHandler of the listener.</returns>
+        /// <seealso cref="EventHandler"/>
+        public EventHandler<long> GetListener() => InnerListener ??= DownloadSpeedChangeListener;
 
         private void DownloadSpeedChangeListener(object? sender, long newRequestedSpeed)
         {

HttpResponseInputStream.cs

@@ -18,15 +18,15 @@ namespace Hi3Helper.Http
     public class HttpResponseInputStream : Stream
     {
 #pragma warning disable CS8618 // Non-nullable field must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring as nullable.
-        private protected HttpRequestMessage _networkRequest;
-        private protected HttpResponseMessage _networkResponse;
-        private protected Stream _networkStream;
+        private HttpRequestMessage _networkRequest;
+        private HttpResponseMessage _networkResponse;
+        private Stream _networkStream;
 #pragma warning restore CS8618 // Non-nullable field must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring as nullable.
 
-        private protected long _networkLength;
-        private protected long _currentPosition;
-        public HttpStatusCode _statusCode;
-        public bool _isSuccessStatusCode;
+        private long           _networkLength;
+        private long           _currentPosition;
+        private HttpStatusCode _statusCode;
+        private bool           _isSuccessStatusCode;
 
         public static async Task<HttpResponseInputStream?> CreateStreamAsync(
             HttpClient client,
@@ -232,9 +232,9 @@ protected override void Dispose(bool disposing)
         {
             if (disposing)
             {
-                _networkRequest?.Dispose();
-                _networkResponse?.Dispose();
-                _networkStream?.Dispose();
+                _networkRequest.Dispose();
+                _networkResponse.Dispose();
+                _networkStream.Dispose();
             }
 
             GC.SuppressFinalize(this);
@@ -243,11 +243,10 @@ protected override void Dispose(bool disposing)
 #if NET6_0_OR_GREATER
         public override async ValueTask DisposeAsync()
         {
-            _networkRequest?.Dispose();
-            _networkResponse?.Dispose();
-            if (_networkStream != null)
-                await _networkStream.DisposeAsync();
-
+            _networkRequest.Dispose();
+            _networkResponse.Dispose();
+            await _networkStream.DisposeAsync();
+            
             GC.SuppressFinalize(this);
         }
 #endif

LogEvent.cs

@@ -1,4 +1,5 @@
 using System;
+// ReSharper disable UnusedAutoPropertyAccessor.Global
 
 // ReSharper disable UnusedMember.Global
 

Utility.cs

@@ -67,7 +67,7 @@ internal static bool IsStreamCanSeeLength(this Stream stream)
         {
             try
             {
-                long len = stream.Length;
+                _ = stream.Length;
                 return true;
             }
             catch { return false; }