Skip to content

Various Patch Fixes#4502

Open
N7Huntsman wants to merge 5 commits intoDevelopmentfrom
Various-Patch-Stuff
Open

Various Patch Fixes#4502
N7Huntsman wants to merge 5 commits intoDevelopmentfrom
Various-Patch-Stuff

Conversation

@N7Huntsman
Copy link
Copy Markdown
Contributor

@N7Huntsman N7Huntsman commented Mar 17, 2026 •
edited
Loading

Changes

  • Patch Red Wood (AM/AB), Eyeling (AA/AM) and Raw Fish (VAE-E/VFE) in other mods where they occur.
  • Fix typo in VWE lever action rifle.

Reasoning

  • defNames are identical. Patching is very defensive to prevent issues when using mods where multiple occur.

Alternatives

  • Leave unpatched.
  • World's slowest lever-action.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@N7Huntsman N7Huntsman requested review from a team as code owners March 17, 2026 03:54
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 17, 2026

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-23177631000.zip

@github-actions github-actions Bot added the Download in Comments This PR has a zipfile download available. label Mar 17, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 25, 2026

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-23566946889.zip

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 25, 2026

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-23567040680.zip

Safairette
Safairette reviewed Apr 19, 2026
View reviewed changes
Comment thread ModPatches/Alpha Memes/Patches/Alpha Memes/ThingDefs_Items/AM_Resource_CE_Stuff.xml
</match>
</Operation>

<Operation Class="PatchOperationConditional">
Copy link
Copy Markdown
Contributor

@Safairette Safairette Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the point of this conditional when both the branches end up applying the same Replace?

Safairette
Safairette reviewed Apr 19, 2026
View reviewed changes
Comment thread ...nimals Expanded - Endangered/Patches/Vanilla Animals Expanded - Endangered/VAE_Resources.xml
</nomatch>
</Operation>

<Operation Class="PatchOperationConditional">
Copy link
Copy Markdown
Contributor

@Safairette Safairette Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question for this conditional, both branches end up applying the same Add

Safairette
Safairette reviewed Apr 19, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Safairette Safairette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes do work, but I'd like to know the reasons for the Conditionals before approving.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 19, 2026

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-24639599167.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Safairette Safairette Safairette approved these changes

Assignees

No one assigned

Labels

Download in Comments This PR has a zipfile download available.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@N7Huntsman @Safairette