Good practices hidden

Author: Pietro

app/models/story.rb

@@ -136,7 +136,8 @@ def check_type
 
     # The queries are performed only if needed
     update_column(:welfare_provision, is_wp) if is_wp != welfare_provision?
-    update_column(:good_practice, is_gp) if is_gp != good_practice?
+    # No more good_practice
+    # update_column(:good_practice, is_gp) if is_gp != good_practice?
     update_column(:tutorial, is_tutorial) if is_tutorial != tutorial?
   end
 

app/views/layouts/_navbar.html.erb

@@ -37,9 +37,9 @@
       <li class="nav-item active">
         <%= link_to s_('Navbar|Commoners Voices'), stories_path(filter: :commoners_voice), class: 'nav-link nav-item--single-line' %>
       </li>
-      <li class="nav-item active">
-        <%= link_to s_('Navbar|Good Practices'), stories_path(filter: :good_practice), class: 'nav-link nav-item--single-line' %>
-      </li>
+      <!-- <li class="nav-item active"> -->
+        <%#= link_to s_('Navbar|Good Practices'), stories_path(filter: :good_practice), class: 'nav-link nav-item--single-line' %>
+      <!-- </li> -->
       <li class="nav-item active">
         <%= link_to s_('Navbar|Public Benefits'), stories_path(filter: :welfare_provision), class: 'nav-link nav-item--single-line' %>
       </li>

db/migrate/20190402071356_add_was_good_practice_to_stories.rb

@@ -0,0 +1,14 @@
+class AddWasGoodPracticeToStories < ActiveRecord::Migration[5.1]
+  def change
+    add_column :stories, :was_good_practice, :boolean, default: false
+    add_index :stories, :was_good_practice
+
+    # Update existing Good Practices
+    Story.find_each do |story|
+      if story.good_practice?
+        story.update_column(:was_good_practice, true)
+        story.update_column(:good_practice, false)
+      end
+    end
+  end
+end

db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 20190122121229) do
+ActiveRecord::Schema.define(version: 20190402071356) do
 
   # These are extensions that must be enabled in order to support this database
   enable_extension "plpgsql"
@@ -220,12 +220,14 @@
     t.bigint "group_id"
     t.jsonb "template_json"
     t.boolean "tutorial", default: false
+    t.boolean "was_good_practice", default: false
     t.index ["anonymous"], name: "index_stories_on_anonymous"
     t.index ["commoner_id"], name: "index_stories_on_commoner_id"
     t.index ["good_practice"], name: "index_stories_on_good_practice"
     t.index ["group_id"], name: "index_stories_on_group_id"
     t.index ["slug"], name: "index_stories_on_slug", unique: true
     t.index ["tutorial"], name: "index_stories_on_tutorial"
+    t.index ["was_good_practice"], name: "index_stories_on_was_good_practice"
     t.index ["welfare_provision"], name: "index_stories_on_welfare_provision"
   end