Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal ADC Channel sampling #107

Open
Candas1 opened this issue Aug 7, 2023 · 2 comments
Open

Internal ADC Channel sampling #107

Candas1 opened this issue Aug 7, 2023 · 2 comments

Comments

@Candas1
Copy link

Candas1 commented Aug 7, 2023 •
edited
Loading

Hi,

If an internal ADC Channel like temperature or voltage reference is requested to analogRead (I haven't tested this yet), a higher sampling time (ADC_SAMPLETIME_239POINT5 ?) could be used here.
@Candas1
Copy link
Author

Candas1 commented Aug 7, 2023

Hmm I think this is also missing if I am not wrong.

@Candas1
Copy link
Author

Candas1 commented Aug 28, 2023

This is also wrong.
Pinmode should be set only if it's not an internal ADC channel, otherwise fails (in default branch of the switch).

I experimented with VREF but it was messing up my other readings.
If I find a solution to this I can propose a PR for all the issues I mentioned if it helps.

maxgerhardt added a commit that referenced this issue Jun 9, 2024
@maxgerhardt
Merge pull request #130 from michpro/FIX-107
0f853a9 
Improved support for ADC internal channels - VSENSE and VREFINT (#107)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Candas1