Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default WinUI version for .bat solution generation #261

Closed
Arlodotexe opened this issue Feb 20, 2025 · 0 comments · Fixed by #263
Closed

Fix default WinUI version for .bat solution generation #261

Arlodotexe opened this issue Feb 20, 2025 · 0 comments · Fixed by #263
Assignees
Labels
bug 🐛 Something isn't working dev loop ➰ For issues that impact the core dev-loop of building experiments

Comments

@Arlodotexe
Copy link
Member

Background

See:

If you need to work with WinUI 3 / Wasdk instead of our default (uwp), pass the -winui 3 parameter in when generating the solution:

.\tooling\GenerateAllSolution.ps1 -MultiTargets wasdk,wasm,android,ios -Components Media,SettingsControls -winui 3 

The Components and MultiTargets params can be customized as needed for your scenario. Removing these params will generate uwp or wasdk + wasm, depending on the -winui value given.

The use case for the GenerateAllSolution.bat is to provide a double-click option from the file explorer.

Problem

The GenerateAllSolution.bat file doesn't appear to provide a way to use WinUI 3 without knowing how to call the underlying PowerShell script in our tooling instead.

This shouldn't be the case. At minimum, WinUI 3 should be the default, as the Windows App SDK is the recommended framework from Microsoft.

Solution

We need to either:

  • Allow choosing between winui 2 and 3 via two separate .bat files
  • Change the default winui version when using the bat file to winui 3
@Arlodotexe Arlodotexe added bug 🐛 Something isn't working dev loop ➰ For issues that impact the core dev-loop of building experiments labels Feb 20, 2025
@Arlodotexe Arlodotexe moved this to 🔖 Ready in Toolkit 8.x Feb 20, 2025
@Arlodotexe Arlodotexe self-assigned this Feb 20, 2025
@Arlodotexe Arlodotexe moved this from 🔖 Ready to 🏗 In progress in Toolkit 8.x Feb 26, 2025
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Toolkit 8.x Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working dev loop ➰ For issues that impact the core dev-loop of building experiments
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant