This repository was archived by the owner on Feb 25, 2026. It is now read-only.
Repository navigation
This repository was archived by the owner on Feb 25, 2026. It is now read-only.
ThemeListener not disposed in sample #3555
Description
The sample ThemeListenerPage does not implement any kind of disposing for the (IDisposable)ThemeListener.
I believe this should be fixed? Might also be a good idea to update the code sample in the docs.
Activity
[-]ThemeListener not disposed[/-][+]ThemeListener not disposed in sample[/+]michael-hawker commentedon Nov 5, 2020
Thanks @Marv51, yeah we don't really show how to dispose this. Though I'm wondering @Sergio0694 @azchohfi should this helper be an instance or something vs. creating multiples? Thoughts?
Doc link for reference.
azchohfi commentedon Nov 5, 2020
I think the implementation itself is fine. Its only the sample app that is not disposing it properly, so we should update that.