Skip to content

Commit 5ff470b

Browse files
committed
Rename solution, readme and icon files
- Rename NuGet Icon to `Icon.png`: - This is no longer used as a public reference point for NuGet icon URL. - Also, Icon URL is deprecated. Hence, it's safe to change. - Normalize casing for `ReadMe.md`: - To match the file already in Windows toolkit repo. - Rename solution file to `CommunityToolkit.sln`: - The `dotnet` seems implied and also doesn't stand-out in the file list because of the lower casing and `d` char. - Spaces are a main issue when doing automation (_like using `*.sln` in build scripts and in URLs it adds `%20`_). - Don't exclude T4 Generated sources in git ignores list. - Indent text in `ThirdPartyNotices.txt` with spaces instead.
1 parent 540fa1c commit 5ff470b

7 files changed

+18
-15
lines changed

.gitignore

+13-9
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
[Ll]og/
1616
[Ll]ogs/
1717

18-
# Generated file from .ttinclude
19-
**/Generated/*.g.cs
18+
# T4 Template Generated files
19+
!**/Generated/*.g.cs
2020

2121
# MSBuild Binary and Structured Log
2222
*.binlog
@@ -31,14 +31,21 @@
3131
# Visual Studio 15+ auto generated files
3232
Generated\ Files/
3333

34+
# Backup folder for Package Reference Convert tool in Visual Studio 2017
35+
MigrationBackup/
36+
37+
# Live Unit Testing for Visual Studio
38+
.lutignore
39+
*.lutconfig
40+
3441
# Local History for Visual Studio
3542
.localhistory/
3643

3744
# Visual Studio History (VSHistory) files
3845
.vshistory/
3946

40-
# Backup folder for Package Reference Convert tool in Visual Studio 2017
41-
MigrationBackup/
47+
# Local History for Visual Studio Code
48+
.history/
4249

4350
# VS Code files for those working on multiple tools
4451
.vscode/*
@@ -48,9 +55,6 @@ MigrationBackup/
4855
!.vscode/extensions.json
4956
*.code-workspace
5057

51-
# Local History for Visual Studio Code
52-
.history/
53-
5458
# MSTest test Results
5559
[Tt]est[Rr]esult*/
5660
[Bb]uild[Ll]og.*
@@ -98,7 +102,7 @@ StyleCopReport.xml
98102
*.tlog
99103
*.vspscc
100104
*.vssscc
101-
.builds
105+
*.builds
102106
*.pidb
103107
*.svclog
104108
*.scc
@@ -180,7 +184,7 @@ _pkginfo.txt
180184

181185
# Others
182186
ClientBin/
183-
~$*
187+
~*
184188
*~
185189
*~.*
186190
*.dbmdl

dotnet Community Toolkit.sln renamed to CommunityToolkit.sln

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Docs", "Docs", "{88C6FFBE-3
3030
CODE_OF_CONDUCT.md = CODE_OF_CONDUCT.md
3131
Contributing.md = Contributing.md
3232
License.md = License.md
33-
README.md = README.md
33+
ReadMe.md = ReadMe.md
3434
ThirdPartyNotices.txt = ThirdPartyNotices.txt
3535
EndProjectSection
3636
EndProject

README.md renamed to ReadMe.md

File renamed without changes.

ThirdPartyNotices.txt

+3-3
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@ Do Not Translate or Localize
55

66
This project incorporates components from the projects listed below. The original copyright notices and the licenses under which the .NET Foundation received such components are set forth below. The .NET Foundation reserves all rights not expressly granted herein, whether by implication, estoppel or otherwise.
77

8-
1. PedroLamas/DeferredEvents version 1.0.4 (https://github.com/PedroLamas/DeferredEvents), included in CommunityToolkit.Common/Deferred.
9-
2. MichaeIDietrich/UwpNotificationNetCoreTest commit 5c1a4a3 (https://github.com/MichaeIDietrich/UwpNotificationNetCoreTest), used in DesktopNotificationManagerCompat.cs to support .NET Core 3.0.
10-
3. lbugnion/mvvmlight commit 4cbf77c (https://github.com/lbugnion/mvvmlight), from which some APIs from the `CommunityToolkit.Mvvm` package take inspiration from.
8+
1. PedroLamas/DeferredEvents version 1.0.4 (https://github.com/PedroLamas/DeferredEvents), included in CommunityToolkit.Common/Deferred.
9+
2. MichaeIDietrich/UwpNotificationNetCoreTest commit 5c1a4a3 (https://github.com/MichaeIDietrich/UwpNotificationNetCoreTest), used in DesktopNotificationManagerCompat.cs to support .NET Core 3.0.
10+
3. lbugnion/mvvmlight commit 4cbf77c (https://github.com/lbugnion/mvvmlight), from which some APIs from the `CommunityToolkit.Mvvm` package take inspiration from.
1111
4. PrivateObject/PrivateType (https://github.com/microsoft/testfx/tree/664ac7c2ac9dbfbee9d2a0ef560cfd72449dfe34/src/TestFramework/Extension.Desktop), included in UnitTests.
1212
5. QuinnDamerell/UniversalMarkdown (https://github.com/QuinnDamerell/UniversalMarkdown) contributed by Quinn Damerell and Paul Bartrum for the MarkdownTextBlock control, relicensed to this .NET Foundation project under the MIT license upon contribution in https://github.com/CommunityToolkit/WindowsCommunityToolkit/pull/772.
1313
6. qmatteoq/DesktopBridgeHelpers commit e278153 (https://github.com/qmatteoq/DesktopBridgeHelpers), contributed by Matteo Pagani to identify if running with identity in DesktopNotificationManagerCompat.cs and DesktopBridgeHelpers.cs, relicensed to this .NET Foundation project under the MIT license upon contribution in https://github.com/CommunityToolkit/WindowsCommunityToolkit/pull/3457.

build/Community.Toolkit.Common.props

-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
<PackageProjectUrl>https://github.com/CommunityToolkit/dotnet</PackageProjectUrl>
1212
<PackageReleaseNotes>https://github.com/CommunityToolkit/dotnet/releases</PackageReleaseNotes>
1313
<PackageIcon>Icon.png</PackageIcon>
14-
<PackageIconUrl>https://raw.githubusercontent.com/CommunityToolkit/dotnet/main/build/nuget.png</PackageIconUrl>
1514
</PropertyGroup>
1615

1716
<PropertyGroup>

build/Community.Toolkit.Common.targets

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
</PropertyGroup>
1313

1414
<ItemGroup Condition="$(IsPackable)">
15-
<None Include="$(BuildToolsDirectory)nuget.png" Pack="true" PackagePath="\Icon.png" Visible="False" />
15+
<None Include="$(BuildToolsDirectory)Icon.png" Pack="true" PackagePath="\" Visible="False" />
1616
<None Include="$(RepositoryDirectory)License.md" Pack="true" PackagePath="\" Visible="False" />
1717
<None Include="$(RepositoryDirectory)ThirdPartyNotices.txt" Pack="true" PackagePath="\" Visible="False" />
1818
</ItemGroup>
File renamed without changes.

0 commit comments

Comments
 (0)