Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignoreCommits set to false, commits not checked? #24

Open
MadeInPierre opened this issue Mar 5, 2023 · 1 comment
Open

ignoreCommits set to false, commits not checked? #24

MadeInPierre opened this issue Mar 5, 2023 · 1 comment

Comments

@MadeInPierre
Copy link

Expected Behavior

Hi! I just tried this action with:

  • rules remained as default
  • commitTitleMatch to false
  • ignoreCommits to false

I expect to check if the PR title is correct as well as the commits in the PR.

Actual Behavior

Here is a simple test with empty commits that do not follow the naming convention (but the PR title does). The checks pass:

image

Isn't it supposed to fail since the commits inside the PR are not valid? Thanks for your help!

Steps to Reproduce the Problem

The attached image is sufficient to reproduce this issue.

@sam3k
Copy link

sam3k commented Nov 8, 2023

It seems like the intention of this action is to not lint commits if there is more than one commit in the PR. Not sure why; but I was hoping there was an option to lint all commits as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants