remove other and orth error types from grammar_model.py chat history

Author: alovg

chatbot/grammar_correction.py

@@ -9,7 +9,7 @@ class GrammarModel(Gramformer):
     """
     def __init__(self, models=1, use_gpu=False, seed=1212):
         self.gm = super().__init__(models=1, use_gpu=False)
-
+        self.ignore_errors = ['OTHER', 'ORTH']
 
     def grammar_correction(self,last_user_input):
         """
@@ -39,8 +39,9 @@ def add_correction_to_chat_history(self, chat_history):
         last_user_input = chat_history[-1].get('text')
         corrected_sentence, correction_message = self.grammar_correction(last_user_input)
         error_types = self.get_edits(last_user_input, corrected_sentence)
+        overlap_ignore_errors = any(item in error_types for item in self.ignore_errors)
 
-        if correction_message:
+        if correction_message and (overlap_ignore_errors is False):
             chat_history.append(
                 {
                     'sender': 'bot',

chatbot/notebooks/grammar_model_improvements.ipynb

@@ -215,7 +215,7 @@
   },
   {
    "cell_type": "code",
-   "execution_count": 255,
+   "execution_count": 327,
    "metadata": {},
    "outputs": [],
    "source": [
@@ -225,7 +225,7 @@
     "    \"\"\"\n",
     "    def __init__(self, models=1, use_gpu=False, seed=1212):\n",
     "        self.gm = super().__init__(models=1, use_gpu=False)\n",
-    "        #self.ignore_error_types = [['OTHER'], ['ORTH']]\n",
+    "        self.ignore_errors = ['OTHER', 'ORTH']\n",
     "\n",
     "\n",
     "    def grammar_correction(self,last_user_input):\n",
@@ -256,11 +256,9 @@
     "        last_user_input = chat_history[-1].get('text')\n",
     "        corrected_sentence, correction_message = self.grammar_correction(last_user_input)\n",
     "        error_types = self.get_edits(last_user_input, corrected_sentence)\n",
-    "        ignore_error_types = ['OTHER', 'ORTH']\n",
-    "        set1 = set(error_types)\n",
-    "        set2 = set(ignore_error_types)\n",
+    "        overlap_ignore_errors = any(item in error_types for item in self.ignore_errors)\n",
     "\n",
-    "        if correction_message and (set1.intersection(set2) == True):\n",
+    "        if correction_message and (overlap_ignore_errors is False):\n",
     "            chat_history.append(\n",
     "                {\n",
     "                    'sender': 'bot',\n",
@@ -297,7 +295,7 @@
   },
   {
    "cell_type": "code",
-   "execution_count": 256,
+   "execution_count": 328,
    "metadata": {},
    "outputs": [
     {
@@ -314,7 +312,7 @@
   },
   {
    "cell_type": "code",
-   "execution_count": 257,
+   "execution_count": 341,
    "metadata": {},
    "outputs": [],
    "source": [
@@ -323,7 +321,7 @@
   },
   {
    "cell_type": "code",
-   "execution_count": 262,
+   "execution_count": 342,
    "metadata": {},
    "outputs": [],
    "source": [
@@ -332,16 +330,20 @@
   },
   {
    "cell_type": "code",
-   "execution_count": 263,
+   "execution_count": 343,
    "metadata": {},
    "outputs": [
     {
      "data": {
       "text/plain": [
-       "[{'sender': 'User', 'text': 'Hi bot'}]"
+       "[{'sender': 'User', 'text': 'Hi bot'},\n",
+       " {'sender': 'bot',\n",
+       "  'text': 'This would be better said like this:  \"Hi booch!\" ',\n",
+       "  'correction': True,\n",
+       "  'error_type': ['NOUN']}]"
       ]
      },
-     "execution_count": 263,
+     "execution_count": 343,
      "metadata": {},
      "output_type": "execute_result"
     }