fix(settings): improve fault tolerance and fix TypeScript errors in settings components

- Fix ProfileManager.tsx: Add proper async/await for exportProfile and importProfile
- Fix ProfileManager.tsx: Handle Date | number type for formatDate function
- Fix ProfileManager.tsx: Correct createProfile call to match API signature (2 params, not 3)
- Fix SettingsContext.tsx: Fix deepMerge function to handle PartialCortexSettings type
- Fix SettingsContext.tsx: Properly cast CustomEvent handlers to EventListener via unknown
- Fix SettingsContext.tsx: Remove unused destructured variables in useWorkbenchEditorSettings
- Fix PolicySettingsContext.tsx: Remove unused imports (createSignal, createEffect)
- Fix profiles/ProfileManager.tsx: Remove unused imports and activeProfile variable

These fixes improve configuration persistence reliability and prevent 'Cannot read properties of undefined' errors.

Author: factorydroid

cortex-gui/src/components/profiles/ProfileManager.tsx

@@ -1,6 +1,5 @@
-import { Show, For, createSignal, createEffect, createMemo } from "solid-js";
-import { Portal } from "solid-js/web";
-import { useProfiles, type Profile, type KeyBinding } from "@/context/ProfilesContext";
+import { Show, For, createSignal, createEffect } from "solid-js";
+import { useProfiles, type Profile } from "@/context/ProfilesContext";
 import { Button, Input, Modal, IconButton, Text, Divider, Badge } from "@/components/ui";
 import { getProfileIcon } from "./ProfileSwitcher";
 import { Icon } from "../ui/Icon";
@@ -11,7 +10,6 @@ type ManagerView = "list" | "edit" | "create";
 export function ProfileManager() {
   const {
     profiles,
-    activeProfile,
     activeProfileId,
     showManager,
     closeManager,

cortex-gui/src/components/settings/ProfileManager.tsx

@@ -76,8 +76,8 @@ export function ProfileManager() {
     }
   };
 
-  const handleExport = (profileId: string) => {
-    const json = profiles.exportProfile(profileId);
+  const handleExport = async (profileId: string) => {
+    const json = await profiles.exportProfile(profileId);
     if (json) {
       const profile = profiles.profiles().find((p) => p.id === profileId);
       const filename = `profile-${profile?.name || "export"}-${Date.now()}.json`;
@@ -104,7 +104,7 @@ export function ProfileManager() {
 
       try {
         const text = await file.text();
-        const result = profiles.importProfile(text);
+        const result = await profiles.importProfile(text);
         if (result.success && result.profile) {
           setImportSuccess(`Imported profile: ${result.profile.name}`);
         } else {
@@ -136,8 +136,10 @@ export function ProfileManager() {
     setShowIconPicker(null);
   };
 
-  const formatDate = (timestamp: number): string => {
-    const date = new Date(timestamp);
+  const formatDate = (dateOrTimestamp: Date | number): string => {
+    const date = typeof dateOrTimestamp === 'number' 
+      ? new Date(dateOrTimestamp) 
+      : dateOrTimestamp;
     return date.toLocaleDateString(undefined, {
       year: "numeric",
       month: "short",
@@ -437,8 +439,14 @@ export function ProfileManager() {
       <Show when={showCreateModal()}>
         <CreateProfileModal
           onClose={() => setShowCreateModal(false)}
-          onCreate={(name, icon, copyFromCurrent) => {
-            profiles.createProfile(name, icon, copyFromCurrent);
+          onCreate={async (name, icon, copyFromCurrent) => {
+            // Create profile (optionally copying from current active profile)
+            const copyFromId = copyFromCurrent ? profiles.activeProfileId() : undefined;
+            const newProfile = await profiles.createProfile(name, copyFromId ?? undefined);
+            // Set the icon if specified
+            if (icon && newProfile?.id) {
+              await profiles.setProfileIcon(newProfile.id, icon);
+            }
             setShowCreateModal(false);
           }}
           icons={profiles.getAvailableIcons()}

cortex-gui/src/context/PolicySettingsContext.tsx

@@ -19,9 +19,7 @@ import {
   createContext,
   useContext,
   ParentProps,
-  createSignal,
   createMemo,
-  createEffect,
   onMount,
   onCleanup,
   Accessor,

cortex-gui/src/context/SettingsContext.tsx

@@ -1051,15 +1051,16 @@ const SettingsContext = createContext<SettingsContextValue>();
  * Deep merge two objects with proper type safety.
  * Source values override target values, with recursive merging for nested objects.
  * @param target - The base object to merge into
- * @param source - The object with values to merge (can be partial)
+ * @param source - The object with values to merge (can be partial or PartialCortexSettings)
  * @returns A new merged object of type T
  */
-function deepMerge<T extends object>(target: T, source: Partial<T>): T {
+function deepMerge<T extends object>(target: T, source: Partial<T> | PartialCortexSettings): T {
   const result = { ...target };
+  const sourceRecord = source as Record<string, unknown>;
 
   for (const key in source) {
     if (Object.prototype.hasOwnProperty.call(source, key)) {
-      const sourceValue = source[key as keyof T];
+      const sourceValue = sourceRecord[key];
       const targetValue = target[key as keyof T];
 
       // Recursively merge nested objects (excluding arrays)
@@ -1707,11 +1708,11 @@ const updateCommandPaletteSetting = async <K extends keyof CommandPaletteSetting
   createEffect(() => {
     const handleFolderAdded = (e: CustomEvent<{ path: string }>) => loadFolderSettings(e.detail.path);
     const handleFolderRemoved = (e: CustomEvent<{ path: string }>) => clearFolderSettings(e.detail.path);
-    window.addEventListener("workspace:folder-added", handleFolderAdded as EventListener);
-    window.addEventListener("workspace:folder-removed", handleFolderRemoved as EventListener);
+    window.addEventListener("workspace:folder-added", handleFolderAdded as unknown as EventListener);
+    window.addEventListener("workspace:folder-removed", handleFolderRemoved as unknown as EventListener);
     onCleanup(() => {
-      window.removeEventListener("workspace:folder-added", handleFolderAdded as EventListener);
-      window.removeEventListener("workspace:folder-removed", handleFolderRemoved as EventListener);
+      window.removeEventListener("workspace:folder-added", handleFolderAdded as unknown as EventListener);
+      window.removeEventListener("workspace:folder-removed", handleFolderRemoved as unknown as EventListener);
     });
   });
 
@@ -1741,9 +1742,9 @@ const updateCommandPaletteSetting = async <K extends keyof CommandPaletteSetting
         }
       }
     };
-    window.addEventListener("settings:toggle", handleSettingsToggle as EventListener);
+    window.addEventListener("settings:toggle", handleSettingsToggle as unknown as EventListener);
     onCleanup(() => {
-      window.removeEventListener("settings:toggle", handleSettingsToggle as EventListener);
+      window.removeEventListener("settings:toggle", handleSettingsToggle as unknown as EventListener);
     });
   });
 
@@ -2044,7 +2045,7 @@ export function useCommandPaletteSettings() {
 }
 
 export function useWorkbenchEditorSettings() {
-  const { effectiveSettings, updateWorkbenchEditorSetting, resetSection, getSettingSource, hasWorkspaceOverride, setWorkspaceSetting, resetWorkspaceSetting } = useSettings();
+  const { effectiveSettings, updateWorkbenchEditorSetting, resetSection } = useSettings();
   return {
     settings: () => effectiveSettings().workbench?.editor ?? DEFAULT_WORKBENCH_EDITOR,
     update: updateWorkbenchEditorSetting,