-
Notifications
You must be signed in to change notification settings - Fork 654
Bug: autoRecallTimeoutMs declared in PluginConfig interface but missing from parsePluginConfig return #467
Copy link
Copy link
Open
Description
Bug Description
autoRecallTimeoutMs is declared in the PluginConfig interface (line 105), and used in the code at line 2261:
const AUTO_RECALL_TIMEOUT_MS = parsePositiveInt(config.autoRecallTimeoutMs) ?? 3_000;However, it is completely missing from the parsePluginConfig return object, so the user-supplied value is never parsed, always falls back to the hardcoded default of 3000ms, and the config validator rejects the setting with:
Config invalid
plugins.entries.memory-lancedb-pro.config: invalid config: must NOT have additional properties
Root Cause
parsePluginConfig (line 3733+) builds the return object but skips autoRecallTimeoutMs. The interface has it (line 105), the code reads it, but parsePluginConfig never extracts it from cfg.
Fix
Add to the parsePluginConfig return object, between autoRecallMinRepeated and autoRecallMaxItems:
autoRecallTimeoutMs: parsePositiveInt(cfg.autoRecallTimeoutMs),Impact
- Users cannot configure
autoRecallTimeoutMsviaopenclaw.json(validation error) - Remote embedding APIs that need longer timeout (>5s) cannot be supported
- Fix is a one-liner addition to the return object
Environment
- Plugin version: v1.1.0-beta.10
Reference
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels