Skip to content

Add error toast on failed wallet sign #400

Description

@Baskarayelu

Summary

Differentiate between user-rejection (silent) and unexpected errors (toast).

Background

The current behaviour does not match the documented or expected behaviour. The fix should restore the intended semantics rather than paper over the symptom, and the same fix should be reachable through a regression test so it does not come back.

Acceptance criteria

  • The change matches the summary above.
  • A regression test that fails before the fix and passes after.
  • The PR description names the user-visible impact and any mitigations users were applying.
  • Lint, type-check, and tests all pass locally.
  • PR description references this issue with Closes #<this-issue>.

Implementation hints

  • Start with a failing test that reproduces the bug, then write the fix. Land both in the same PR.
  • If the bug was hidden by an over-broad catch/unwrap, tighten the error path while you are there.
  • Verify the fix in the dev environment (or via the equivalent integration test) before requesting review.
  • Note the user-visible impact in the PR description so the release notes can pick it up.

Repo-specific notes

  • Run npm run lint, npm run build, and the unit tests locally before pushing.
  • If you change a public component prop, update the matching Storybook story and the docs/COMPONENTS.md entry.
  • Respect the design tokens (CSS variables / Tailwind config); do not hard-code colours, spacing, or radii.

Out of scope

  • Unrelated refactors in adjacent files.
  • Stylistic-only changes (formatting, renaming) that are not required by the fix.
  • Anything beyond the acceptance criteria above; surface follow-ups as separate issues.

How to claim and submit

  1. Comment on this issue saying you'd like to take it on; wait for a maintainer to assign you (avoids duplicated effort).
  2. Open a PR that references this issue (Closes #<this-issue>).
  3. Make sure CI is green and request review from a CODEOWNERS maintainer.
  4. PRs that close this issue and pass review may qualify for a reward — see the MAYBE REWARDED label and the GrantFox OSS campaign page.

Category: bug  ·  Campaign: GrantFox OSS · Official Campaign · Maybe Rewarded

Metadata

Metadata

Labels

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions