Upgrade to PHP 8.2 with Rector

Author: Marvin Durot

composer.json

@@ -9,7 +9,7 @@
     }
   ],
   "require" : {
-    "php" : ">=8.1",
+    "php" : ">=8.2",
     "php-curl-class/php-curl-class": "^8.3",
     "psr/cache": "^1.0 || ^2.0 || ^3.0"
   },

rector.php

@@ -9,7 +9,7 @@
         __DIR__ . '/src',
         __DIR__ . '/tests',
     ])
-    ->withPhpSets(php81: true)
+    ->withPhpSets(php82: true)
     ->withTypeCoverageLevel(0)
     ->withDeadCodeLevel(0)
     ->withCodeQualityLevel(0);

src/Api.php

@@ -52,7 +52,7 @@ public function __call($name, $arguments)
             return $this->$name(...$arguments);
         }
 
-        preg_match('/^(get|create|update|delete)([\w\-_\/]+?)$/', $name, $matches);
+        preg_match('/^(get|create|update|delete)([\w\-_\/]+?)$/', (string) $name, $matches);
 
         $endpoint = lcfirst($matches[2]);
 

src/Bridges/BarryvdhLaravelDebugbar/DebugbarTransportDecorator.php

@@ -29,7 +29,7 @@ class DebugbarTransportDecorator implements TransportInterface
      * @param string             $name
      * @param LaravelDebugbar    $debugbar
      */
-    public function __construct(private TransportInterface $transport, private string $name, ?LaravelDebugbar $debugbar)
+    public function __construct(private readonly TransportInterface $transport, private readonly string $name, ?LaravelDebugbar $debugbar)
     {
         $this->debugbar = $debugbar;
     }

src/Bridges/Symfony/Adapter/ApiWrapperPaginatorAdapter.php

@@ -7,7 +7,7 @@
 
 class ApiWrapperPaginatorAdapter implements \IteratorAggregate, ApiPlatformPaginator
 {
-    public function __construct(private PaginatorInterface $paginator)
+    public function __construct(private readonly PaginatorInterface $paginator)
     {
     }
 

src/Bridges/Symfony/DataProvider/ApiPlatformDataProvider.php

@@ -12,7 +12,7 @@
 
 final class ApiPlatformDataProvider implements ItemDataProviderInterface, CollectionDataProviderInterface, RestrictedDataProviderInterface
 {
-    public function __construct(private ManagerRegistry $managerRegistry)
+    public function __construct(private readonly ManagerRegistry $managerRegistry)
     {
     }
 

src/Bridges/Symfony/Repository.php

@@ -72,7 +72,7 @@ public function getMetadata(): ClassMetadata
     public function find($id)
     {
         return $this->instanciateEntity(
-            $this->getApi()->{'get' . ucfirst($this->class->getEntity())}($id)
+            $this->getApi()->{'get' . ucfirst((string) $this->class->getEntity())}($id)
         );
     }
 
@@ -96,7 +96,7 @@ public function findBy(array $criteria, ?array $orderBy = null, $limit = null, $
         $criteria[static::CRITERIA_LIMIT] = $limit ?? static::DEFAULT_LIMIT;
         $criteria[static::CRITERIA_PAGE] = $page ?? 1;
 
-        $results = $this->getApi()->{'get' . ucfirst($this->class->getEntities())}(
+        $results = $this->getApi()->{'get' . ucfirst((string) $this->class->getEntities())}(
             $this->filterCriteria($criteria)
         );
 

src/Builder.php

@@ -106,7 +106,7 @@ public function findOrFail($field, $value = null)
             return $this->where($this->query)->get()[0] ?? null;
         }
 
-        $data = $this->model->getApi()->{'get'.ucfirst($this->model->getEntity())}($field, $this->getQuery());
+        $data = $this->model->getApi()->{'get'.ucfirst((string) $this->model->getEntity())}($field, $this->getQuery());
 
         return $this->model->newInstance($data, true);
     }

src/Concerns/HasAttributes.php

@@ -133,7 +133,7 @@ protected function castAttribute($key, $value)
      */
     protected function getCastType($key)
     {
-        return trim(strtolower($this->getCasts()[$key]));
+        return trim(strtolower((string) $this->getCasts()[$key]));
     }
 
     /**

src/Exceptions/Handlers/BadRequestErrorHandler.php

@@ -14,7 +14,7 @@ class BadRequestErrorHandler extends AbstractErrorHandler
     /**
      * {@inheritdoc}
      */
-    public function handle(ApiException $exception, array $requestArguments)
+    public function handle(ApiException $exception, array $requestArguments): never
     {
         throw new ApiBadRequestException(
             $exception->getResponse(),

src/Exceptions/Handlers/ForbiddenErrorHandler.php

@@ -14,7 +14,7 @@ class ForbiddenErrorHandler extends AbstractErrorHandler
     /**
      * {@inheritdoc}
      */
-    public function handle(ApiException $exception, array $requestArguments)
+    public function handle(ApiException $exception, array $requestArguments): never
     {
         throw new ApiForbiddenException(
             $exception->getResponse(),

src/Exceptions/Handlers/NotFoundErrorHandler.php

@@ -14,7 +14,7 @@ class NotFoundErrorHandler extends AbstractErrorHandler
     /**
      * {@inheritdoc}
      */
-    public function handle(ApiException $exception, array $requestArguments)
+    public function handle(ApiException $exception, array $requestArguments): never
     {
         throw new ApiEntityNotFoundException(
             $exception->getResponse(),

src/Exceptions/Handlers/UnauthorizedErrorHandler.php

@@ -14,7 +14,7 @@ class UnauthorizedErrorHandler extends AbstractErrorHandler
     /**
      * {@inheritdoc}
      */
-    public function handle(ApiException $exception, array $requestArguments)
+    public function handle(ApiException $exception, array $requestArguments): never
     {
         throw new ApiUnauthorizedException(
             $exception->getResponse(),

src/Model.php

@@ -562,7 +562,7 @@ protected function performUpdate()
         $dirty = $this->getDirty();
 
         if (count($dirty) > 0) {
-            $updatedField = $this->getApi()->{'update'.ucfirst($this->getEntity())}($this->{$this->primaryKey}, $dirty);
+            $updatedField = $this->getApi()->{'update'.ucfirst((string) $this->getEntity())}($this->{$this->primaryKey}, $dirty);
             $this->fill($updatedField);
             $this->syncChanges();
         }
@@ -578,7 +578,7 @@ protected function performUpdate()
     protected function performInsert()
     {
         $attributes = $this->getAttributes();
-        $updatedField = $this->getApi()->{'create'.ucfirst($this->getEntity())}($attributes);
+        $updatedField = $this->getApi()->{'create'.ucfirst((string) $this->getEntity())}($attributes);
         $this->fill($updatedField);
         $this->exists = true;
         $this->wasRecentlyCreated = true;
@@ -593,7 +593,7 @@ protected function performInsert()
      */
     protected function performDeleteOnModel()
     {
-        $this->getApi()->{'delete'.ucfirst($this->getEntity())}(
+        $this->getApi()->{'delete'.ucfirst((string) $this->getEntity())}(
             $this->{$this->primaryKey},
             array_merge(...array_values($this->getGlobalScopes()))
         );

src/Transports/Transport.php

@@ -101,7 +101,7 @@ public function request($endpoint, array $data = [], $method = 'get')
     {
         $rawResponse = $this->rawRequest($endpoint, $data, $method);
         $httpStatusCode = $this->getClient()->httpStatusCode;
-        $response = json_decode($rawResponse, true);
+        $response = json_decode((string) $rawResponse, true);
 
         if ($httpStatusCode >= 200 && $httpStatusCode <= 299) {
             return $response;