Skip to content

Parsing Vault Initialization is still hardcoded at 5 keys instead of dynamic size #4

@aggietallboy

Description

@aggietallboy

First, HUGE thank you for putting this together... I just came across it while working through a tutorial on another site.

At line 1552, you parse the secrets for initializing the vault.

For our org, we wanted to do 7 shares with a threshold of 2.

The script itself does great at actually pushing that, but when it builds the object for the $VaultINITKeys, it makes an assumption that it will have 5 keys.

I did a down-and-dirty cut and paste to expand it for my 7 keys, but a better approach would probably be a foreach loop based on the incoming $initialize variable.

Another possibility, is that the web interface, by default downloads this as a .json file. Possibly just parsing the data a little more "raw" using ConvertFrom-Json would be easier?

I haven't dug in on diagnostics to look at the raw stuff yet, but hopefully this can point this in a direction to make this wonderful toolset a little more generic.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions