-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor bug spatial_skill default binning #43
Comments
Could you explain what the problem is? |
Currently, the default spatial bins will be with respect to the mean x and y of the available track data ('center of gravity'). For the global data for example, this results in default bins, which are not centered near x=0, but shifted to the west (less data for longitudes from 0 to 180 degrees than from -180 to 0 degrees). In the global example this is not visible as the bins are specifically defined. As suggested above, I think it would be nice to instead use the mean of the extend of the data (center of bounding box of data). Even nicer would be to use the center of the bounding box of the domain. However, the domain is not always available. |
Outdated. |
https://github.com/DHI/fmskill/blob/686b146b776ec948dd44398ee736ca8df2aaa1a5/fmskill/compare.py#L611
Better:
np.mean([np.min(x),np.max(x)])
?The text was updated successfully, but these errors were encountered: