-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Missing metrics when logging hyperparameters on tensorboard #1298
Comments
I have the same issue when trying to log hparams metrics |
Co-authored-by: Riccardo Sepe <[email protected]> Co-authored-by: Francesco Scalera <[email protected]>
Co-authored-by: Riccardo Sepe <[email protected]> Co-authored-by: Francesco Scalera <[email protected]>
@timothe-chaumont as you did the implementation in #984, could you have a look?
I would expect |
Co-authored-by: Riccardo Sepe <[email protected]> Co-authored-by: Francesco Scalera <[email protected]>
You are right @rogierz, metric values that are passed to In the documentation, the example mentions: # define the metrics that will appear in the `HPARAMS` Tensorboard tab by referencing their tag
# Tensorbaord will find & display metrics from the `SCALARS` tab
metric_dict = {
"rollout/ep_len_mean": 0,
"train/value_loss": 0.0,
}
new_logger.record("missing_metric", 2.0) so that, when referenced in |
IMHO I might have an idea where this bug comes from: E.g. in HumanOutputFormat one iterates over all keys to output during logger.dump. But the iteration happens together with key_excluded. It is to note that nowhere is it ensured that a loggers.name_to_value and name_to_exclude are the same length (they are public and one might want to use them to do more specific logging then possible just with log_value/mean).. I would suggest the following patch @
Similar changes are needed, e.g., for the TensorboardOutputFormat @
|
🐛 Bug
When I try to log metrics related to some hyperparameters on tensorboard, the values of metrics are not stored.
To Reproduce
Relevant log output / Error message
No response
System Info
Checklist
The text was updated successfully, but these errors were encountered: