Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Procgen #1823

Open
5 tasks done
BurgerAndreas opened this issue Feb 1, 2024 · 3 comments
Open
5 tasks done

[Bug]: Procgen #1823

BurgerAndreas opened this issue Feb 1, 2024 · 3 comments
Labels
check the checklist You have checked the required items in the checklist but you didn't do what is written... documentation Improvements or additions to documentation duplicate This issue or pull request already exists good first issue Good for newcomers help wanted Help from contributors is welcomed

Comments

@BurgerAndreas
Copy link

🐛 Bug

Using Procgen like in the example from the docs website results in:

AssertionError: The algorithm only supports (<class 'gymnasium.spaces.box.Box'>, <class 'gymnasium.spaces.discrete.Discrete'>, <class 'gymnasium.spaces.multi_discrete.MultiDiscrete'>, <class 'gymnasium.spaces.multi_binary.MultiBinary'>) as action spaces but Discrete(15) was provided

To Reproduce

from procgen import ProcgenEnv

from stable_baselines3 import PPO
from stable_baselines3.common.vec_env import VecExtractDictObs, VecMonitor

# ProcgenEnv is already vectorized
venv = ProcgenEnv(num_envs=2, env_name="starpilot")

# To use only part of the observation:
# venv = VecExtractDictObs(venv, "rgb")

# Wrap with a VecMonitor to collect stats and avoid errors
venv = VecMonitor(venv=venv)

model = PPO("MultiInputPolicy", venv, verbose=1)
model.learn(10_000)

Copied from:
https://stable-baselines3.readthedocs.io/en/master/guide/examples.html#sb3-and-procgenenv

Relevant log output / Error message

Traceback (most recent call last):
  File "/ssd/robos/xb/sb3_procgen_bug.py", line 15, in <module>
    model = PPO("MultiInputPolicy", venv, verbose=1)
  File "/ssd/robos/xb/venv10/lib/python3.10/site-packages/stable_baselines3/ppo/ppo.py", line 109, in __init__
    super().__init__(
  File "/ssd/robos/xb/venv10/lib/python3.10/site-packages/stable_baselines3/common/on_policy_algorithm.py", line 85, in __init__
    super().__init__(
  File "/ssd/robos/xb/venv10/lib/python3.10/site-packages/stable_baselines3/common/base_class.py", line 180, in __init__
    assert isinstance(self.action_space, supported_action_spaces), (
AssertionError: The algorithm only supports (<class 'gymnasium.spaces.box.Box'>, <class 'gymnasium.spaces.discrete.Discrete'>, <class 'gymnasium.spaces.multi_discrete.MultiDiscrete'>, <class 'gymnasium.spaces.multi_binary.MultiBinary'>) as action spaces but Discrete(15) was provided
Exception ignored in: <function CEnv.__del__ at 0x7f215900c670>

System Info

  • OS: Linux-6.5.0-14-generic-x86_64-with-glibc2.35 # 14~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC
  • Python: 3.10.12
  • Stable-Baselines3: 2.2.1
  • PyTorch: 2.2.0+cu121
  • GPU Enabled: True
  • Numpy: 1.26.3
  • Cloudpickle: 3.0.0
  • Gymnasium: 0.29.1
  • OpenAI Gym: 0.26.2

Checklist

  • My issue does not relate to a custom gym environment. (Use the custom gym env template instead)
  • I have checked that there is no similar issue in the repo
  • I have read the documentation
  • I have provided a minimal and working example to reproduce the bug
  • I've used the markdown code blocks for both code and stack traces.
@BurgerAndreas BurgerAndreas added the bug Something isn't working label Feb 1, 2024
@araffin araffin added duplicate This issue or pull request already exists check the checklist You have checked the required items in the checklist but you didn't do what is written... documentation Improvements or additions to documentation help wanted Help from contributors is welcomed and removed bug Something isn't working labels Feb 2, 2024
@araffin
Copy link
Member

araffin commented Feb 2, 2024

Duplicate of #1712

I would appreciate a PR that updates the documentation ;)

@araffin araffin added the good first issue Good for newcomers label Mar 1, 2024
@nayers17
Copy link

Hi, I'm interested in helping update the documentation for this issue. Is this still needed?

@araffin
Copy link
Member

araffin commented Sep 18, 2024

yes please =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
check the checklist You have checked the required items in the checklist but you didn't do what is written... documentation Improvements or additions to documentation duplicate This issue or pull request already exists good first issue Good for newcomers help wanted Help from contributors is welcomed
Projects
None yet
Development

No branches or pull requests

3 participants