fix(clippy): resolve all clippy warnings in CI

- Remove unused lifetime parameters in cache and world modules
- Replace io::Error::new with io::Error::other for cleaner API
- Use next_back() instead of last() for double-ended iterators
- Remove needless return statement in GitHub provider
- Add explicit lifetime annotations to ConfigListViewer
- Fix test URL from httpbin.org to mockhttp.org to avoid 503 errors

Author: xz-dev

src/cache.rs

@@ -29,6 +29,6 @@ pub async fn init_cache_manager_with_expire(local_cache_path: &Path, expire_time
         .set_global_expire_time(expire_time);
 }
 
-pub async fn get_cache_manager<'a>() -> Arc<Mutex<CacheManager>> {
+pub async fn get_cache_manager() -> Arc<Mutex<CacheManager>> {
     INSTANCE_CONTAINER.get().await.clone()
 }

src/core/config/world.rs

@@ -18,7 +18,7 @@ pub async fn init_world_list(world_list_path: &Path) -> Result<()> {
     Ok(())
 }
 
-pub async fn get_world_list<'a>() -> Arc<Mutex<WorldList>> {
+pub async fn get_world_list() -> Arc<Mutex<WorldList>> {
     INSTANCE_CONTAINER.get().await.clone()
 }
 

src/utils/http.rs

@@ -256,7 +256,7 @@ mod tests {
 
     #[tokio::test]
     async fn test_https_get_status() {
-        let url = "https://httpbin.org/status/418".parse().unwrap();
+        let url = "https://mockhttp.org/status/418".parse().unwrap();
         let result = https_get(url, &HashMap::new()).await;
         assert_eq!(result.unwrap().status, 418);
     }

src/websdk/cloud_rules/cloud_rules_manager.rs

@@ -30,7 +30,7 @@ impl CloudRules {
         }
     }
 
-    pub fn get_config_list(&self) -> ConfigListViewer {
+    pub fn get_config_list(&self) -> ConfigListViewer<'_> {
         self._config_list
             .as_ref()
             .map_or_else(ConfigListViewer::default, |config_list| {

src/websdk/cloud_rules/data/config_list.rs

@@ -32,7 +32,7 @@ pub struct ConfigList {
 }
 
 impl ConfigList {
-    pub fn viewer(&self) -> ConfigListViewer {
+    pub fn viewer(&self) -> ConfigListViewer<'_> {
         ConfigListViewer {
             app_config_list: self.app_config_list.iter().collect(),
             hub_config_list: self.hub_config_list.iter().collect(),

src/websdk/repo/provider/base_provider.rs

@@ -95,10 +95,7 @@ impl<T> FOut<T> {
 
     pub fn new_empty() -> Self {
         FOut {
-            result: Err(Box::new(std::io::Error::new(
-                std::io::ErrorKind::Other,
-                "no data",
-            ))),
+            result: Err(Box::new(std::io::Error::other("no data"))),
             cached_map: None,
         }
     }

src/websdk/repo/provider/fdroid.rs

@@ -158,7 +158,7 @@ impl FDroidProvider {
             };
         }
         let download_url = format!("{}/{}", url, file_name);
-        let file_type = file_name.split('.').last().unwrap_or("").to_string();
+        let file_type = file_name.split('.').next_back().unwrap_or("").to_string();
 
         let extra = if extra.is_empty() { None } else { Some(extra) };
         Ok(ReleaseData {

src/websdk/repo/provider/github.rs

@@ -36,7 +36,7 @@ impl GitHubProvider {
         if let Some(token) = token {
             map.insert("Authorization".to_string(), format!("Bearer {}", token));
         }
-        return map;
+        map
     }
 }