Skip to content

Commit 77fee60

Browse files
committed
DaemonFileEmbedder: use Str::StringRef
1 parent fccf28e commit 77fee60

File tree

4 files changed

+10
-11
lines changed

4 files changed

+10
-11
lines changed

cmake/DaemonFileEmbedder.cmake

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,15 @@ string(REGEX REPLACE
2929

3030
# A bit more of beautification.
3131
string(REGEX REPLACE ",$" ",\n" contents "${contents}")
32+
set(DATA_VARIABLE_NAME "data_${VARIABLE_NAME}")
3233

3334
file(WRITE ${OUTPUT_FILE}
34-
"constexpr unsigned char ${VARIABLE_NAME}[] =\n"
35+
"constexpr unsigned char ${DATA_VARIABLE_NAME}[] =\n"
3536
"{\n"
3637
"${contents}"
3738
"};\n"
39+
"const Str::StringRef ${VARIABLE_NAME} = {\n"
40+
"reinterpret_cast<const char*>( ${DATA_VARIABLE_NAME} ),\n"
41+
"sizeof ( ${DATA_VARIABLE_NAME} ) - 1\n"
42+
"};\n"
3843
)

cmake/DaemonSourceGenerator.cmake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,11 +123,11 @@ macro(daemon_embed_files basename dir list format targetname)
123123
)
124124

125125
string(APPEND embed_H_text
126-
"extern const unsigned char ${filename_symbol}[];\n"
126+
"extern const Str::StringRef ${filename_symbol};\n"
127127
)
128128

129129
string(APPEND embed_map_text
130-
"\t{ \"${filename}\", { ${filename_symbol}, sizeof( ${filename_symbol}) - 1 } },\n"
130+
"\t{ \"${filename}\", ${filename_symbol} },\n"
131131
)
132132
endforeach()
133133

src/common/EmbeddedFile.h

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,5 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
3030

3131
#ifndef COMMON_EMBEDDEDFILE_H_
3232
#define COMMON_EMBEDDEDFILE_H_
33-
struct embeddedFileMapEntry_t
34-
{
35-
const unsigned char* data;
36-
size_t size;
37-
};
38-
39-
using embeddedFileMap_t = std::unordered_map<std::string, const embeddedFileMapEntry_t>;
33+
using embeddedFileMap_t = std::unordered_map<std::string, const Str::StringRef>;
4034
#endif // COMMON_EMBEDDEDFILE_H_

src/engine/renderer/gl_shader.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ namespace // Implementation details
9494
{
9595
auto it = EngineShaders::FileMap.find(filename);
9696
if (it != EngineShaders::FileMap.end())
97-
return (const char*) it->second.data;
97+
return it->second.data();
9898
return nullptr;
9999
}
100100

0 commit comments

Comments
 (0)