Skip to content

Commit a34c929

Browse files
committed
linux/android: add SIGTRAP to the list of signals handled by the client
__builtin_trap() causes a SIGTRAP on arm64 (at least with GCC 4.9). SIGTRAP is not handled by breakpad, causing crashes induced by __builtin_trap() to be missed. Note that on x86 and arm, instead, __builtin_trap() raises a SIGILL, which is already handled by breakapd. BUG=chromium:614865 [email protected] Review URL: https://codereview.chromium.org/2042853002 .
1 parent 72e94c4 commit a34c929

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/client/linux/handler/exception_handler.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ namespace {
118118
// all these signals must be Core (see man 7 signal) because we rethrow the
119119
// signal after handling it and expect that it'll be fatal.
120120
const int kExceptionSignals[] = {
121-
SIGSEGV, SIGABRT, SIGFPE, SIGILL, SIGBUS
121+
SIGSEGV, SIGABRT, SIGFPE, SIGILL, SIGBUS, SIGTRAP
122122
};
123123
const int kNumHandledSignals =
124124
sizeof(kExceptionSignals) / sizeof(kExceptionSignals[0]);

0 commit comments

Comments
 (0)