Fixed a bunch of warnings

Daniel Everland · Daniel Everland · commit 0503f4677a60 · 2019-02-06T16:43:06.000+01:00
diff --git a/Assets/SO Architecture/Editor/Inspectors/CollectionEditor.cs b/Assets/SO Architecture/Editor/Inspectors/CollectionEditor.cs
@@ -1,8 +1,8 @@
 ﻿using System.Reflection;
 using UnityEditor;
-using UnityEditorInternal;
 using UnityEngine;
 using Type = System.Type;
+using ReorderableList = UnityEditorInternal.ReorderableList;
 
 [CustomEditor(typeof(BaseCollection), true)]
 public class CollectionEditor : Editor
diff --git a/Assets/SO Architecture/Events/Game Events/GameEventBase.cs b/Assets/SO Architecture/Events/Game Events/GameEventBase.cs
@@ -7,7 +7,7 @@ public abstract class GameEventBase<T> : GameEventBase, IGameEvent<T>, IStackTra
     private readonly List<System.Action<T>> _typedActions = new List<System.Action<T>>();
 
     [SerializeField]
-    protected T _debugValue;
+    protected T _debugValue = default(T);
 
     public void Raise(T value)
     {
diff --git a/Assets/SO Architecture/Events/Listeners/BaseGameEventListener.cs b/Assets/SO Architecture/Events/Listeners/BaseGameEventListener.cs
@@ -14,14 +14,14 @@ public abstract class BaseGameEventListener<TType, TEvent, TResponse> : Debuggab
     protected override UnityEventBase Response { get { return _response; } }
 
     [SerializeField]
-    private TEvent _previouslyRegisteredEvent;
+    private TEvent _previouslyRegisteredEvent = default(TEvent);
     [SerializeField]
-    private TEvent _event;
+    private TEvent _event = default(TEvent);
     [SerializeField]
-    private TResponse _response;
+    private TResponse _response = default(TResponse);
     
     [SerializeField]
-    protected TType _debugValue;
+    protected TType _debugValue = default(TType);
 
     public void OnEventRaised(TType value)
     {
@@ -64,11 +64,11 @@ public abstract class BaseGameEventListener<TEvent, TResponse> : DebuggableGameE
     protected override UnityEventBase Response { get { return _response; } }
 
     [SerializeField]
-    private TEvent _previouslyRegisteredEvent;
+    private TEvent _previouslyRegisteredEvent = default(TEvent);
     [SerializeField]
-    private TEvent _event;
+    private TEvent _event = default(TEvent);
     [SerializeField]
-    private TResponse _response;
+    private TResponse _response = default(TResponse);
 
     public void OnEventRaised()
     {
diff --git a/Assets/SO Architecture/Examples/Scripts/CollectionCountDisplayer.cs b/Assets/SO Architecture/Examples/Scripts/CollectionCountDisplayer.cs
@@ -6,9 +6,9 @@
 public class CollectionCountDisplayer : MonoBehaviour
 {
     [SerializeField]
-    private Text _textTarget;
+    private Text _textTarget = default(Text);
     [SerializeField]
-    private BaseCollection _setTarget;
+    private BaseCollection _setTarget = default(BaseCollection);
     [SerializeField]
     private string _textFormat = "There are {0} things.";
 
diff --git a/Assets/SO Architecture/Examples/Scripts/DamageDealer.cs b/Assets/SO Architecture/Examples/Scripts/DamageDealer.cs
@@ -5,7 +5,7 @@
 public class DamageDealer : MonoBehaviour
 {
     [SerializeField]
-    private FloatReference _damageAmount;
+    private FloatReference _damageAmount = default(FloatReference);
 
     private void OnTriggerEnter(Collider other)
     {
diff --git a/Assets/SO Architecture/Examples/Scripts/DamageDealerWithEvent.cs b/Assets/SO Architecture/Examples/Scripts/DamageDealerWithEvent.cs
@@ -5,7 +5,7 @@
 public class DamageDealerWithEvent : DamageDealer
 {
     [SerializeField]
-    private GameEvent _onDamagedEvent;
+    private GameEvent _onDamagedEvent = default(GameEvent);
 
     protected override void DealDamage(UnitHealth target)
     {
diff --git a/Assets/SO Architecture/Examples/Scripts/Disabler.cs b/Assets/SO Architecture/Examples/Scripts/Disabler.cs
@@ -5,7 +5,7 @@
 public class Disabler : MonoBehaviour
 {
     [SerializeField]
-    private GameObjectCollection _targetSet;
+    private GameObjectCollection _targetSet = default(GameObjectCollection);
 
     public void DisableRandom()
     {
diff --git a/Assets/SO Architecture/Examples/Scripts/ImageFillSetter.cs b/Assets/SO Architecture/Examples/Scripts/ImageFillSetter.cs
@@ -6,11 +6,11 @@
 public class ImageFillSetter : MonoBehaviour
 {
     [SerializeField]
-    private FloatReference _variable;
+    private FloatReference _variable = default(FloatReference);
     [SerializeField]
-    private FloatReference _maxValue;
+    private FloatReference _maxValue = default(FloatReference);
     [SerializeField]
-    private Image _imageTarget;
+    private Image _imageTarget = default(Image);
 
     private void Update()
     {
diff --git a/Assets/SO Architecture/Examples/Scripts/KeyboardMover.cs b/Assets/SO Architecture/Examples/Scripts/KeyboardMover.cs
@@ -5,7 +5,7 @@
 public class KeyboardMover : MonoBehaviour
 {
     [SerializeField]
-    private FloatReference _moveSpeed;
+    private FloatReference _moveSpeed = default(FloatReference);
 
     private void Update()
     {
diff --git a/Assets/SO Architecture/Examples/Scripts/ObjectAdder.cs b/Assets/SO Architecture/Examples/Scripts/ObjectAdder.cs
@@ -5,7 +5,7 @@
 public class ObjectAdder : MonoBehaviour
 {
     [SerializeField]
-    private GameObjectCollection _targetCollection;
+    private GameObjectCollection _targetCollection = default(GameObjectCollection);
 
     private void OnEnable()
     {
diff --git a/Assets/SO Architecture/Examples/Scripts/UnitHealth.cs b/Assets/SO Architecture/Examples/Scripts/UnitHealth.cs
@@ -9,7 +9,7 @@ public class UnitHealth : MonoBehaviour
     [SerializeField]
     private bool _resetOnStartup = true;
     [SerializeField]
-    private FloatReference _startingHealth;
+    private FloatReference _startingHealth = default(FloatReference);
 
     private void Start()
     {
diff --git a/Assets/SO Architecture/References/BaseReference.cs b/Assets/SO Architecture/References/BaseReference.cs
@@ -13,9 +13,9 @@ public BaseReference(TBase baseValue)
     [SerializeField]
     protected bool _useConstant = false;
     [SerializeField]
-    protected TBase _constantValue;
+    protected TBase _constantValue = default(TBase);
     [SerializeField]
-    protected TVariable _variable;
+    protected TVariable _variable = default(TVariable);
 
     public TBase Value
     {
diff --git a/Assets/SO Architecture/Variables/BaseVariable.cs b/Assets/SO Architecture/Variables/BaseVariable.cs
@@ -36,7 +36,7 @@ public override object BaseValue
     }
 
     [SerializeField]
-    protected T _value;
+    protected T _value = default(T);
     [SerializeField]
     private bool _readOnly = false;
     [SerializeField]
diff --git a/Assets/SO Architecture/Variables/Clamped/ByteClampedVariable.cs b/Assets/SO Architecture/Variables/Clamped/ByteClampedVariable.cs
@@ -10,9 +10,9 @@ public class ByteClampedVariable : ByteVariable, IClampedVariable<byte, ByteVari
     public ByteReference MaxValue { get { return _maxClampedValue; } }
 
     [SerializeField]
-    private ByteReference _minClampedValue;
+    private ByteReference _minClampedValue = default(ByteReference);
     [SerializeField]
-    private ByteReference _maxClampedValue;
+    private ByteReference _maxClampedValue = default(ByteReference);
 
     public virtual byte ClampValue(byte value)
     {
diff --git a/Assets/SO Architecture/Variables/Clamped/DoubleClampedVariable.cs b/Assets/SO Architecture/Variables/Clamped/DoubleClampedVariable.cs
@@ -10,9 +10,9 @@ public class DoubleClampedVariable : DoubleVariable, IClampedVariable<double, Do
     public DoubleReference MaxValue { get { return _maxClampedValue; } }
 
     [SerializeField]
-    private DoubleReference _minClampedValue;
+    private DoubleReference _minClampedValue = default(DoubleReference);
     [SerializeField]
-    private DoubleReference _maxClampedValue;
+    private DoubleReference _maxClampedValue = default(DoubleReference);
 
     public virtual double ClampValue(double value)
     {
diff --git a/Assets/SO Architecture/Variables/Clamped/FloatClampedVariable.cs b/Assets/SO Architecture/Variables/Clamped/FloatClampedVariable.cs
@@ -10,9 +10,9 @@ public class FloatClampedVariable : FloatVariable, IClampedVariable<float, Float
     public FloatReference MaxValue { get { return _maxClampedValue; } }
 
     [SerializeField]
-    private FloatReference _minClampedValue;
+    private FloatReference _minClampedValue = default(FloatReference);
     [SerializeField]
-    private FloatReference _maxClampedValue;
+    private FloatReference _maxClampedValue = default(FloatReference);
 
     public virtual float ClampValue(float value)
     {
diff --git a/Assets/SO Architecture/Variables/Clamped/IntClampedVariable.cs b/Assets/SO Architecture/Variables/Clamped/IntClampedVariable.cs
@@ -10,9 +10,9 @@ public class IntClampedVariable : IntVariable, IClampedVariable<int, IntVariable
     public IntReference MaxValue { get { return _maxClampedValue; } }
 
     [SerializeField]
-    private IntReference _minClampedValue;
+    private IntReference _minClampedValue = default(IntReference);
     [SerializeField]
-    private IntReference _maxClampedValue;
+    private IntReference _maxClampedValue = default(IntReference);
 
     public virtual int ClampValue(int value)
     {
diff --git a/Assets/SO Architecture/Variables/Clamped/LongClampedVariable.cs b/Assets/SO Architecture/Variables/Clamped/LongClampedVariable.cs
@@ -10,9 +10,9 @@ public class LongClampedVariable : LongVariable, IClampedVariable<long, LongVari
     public LongReference MaxValue { get { return _maxClampedValue; } }
 
     [SerializeField]
-    private LongReference _minClampedValue;
+    private LongReference _minClampedValue = default(LongReference);
     [SerializeField]
-    private LongReference _maxClampedValue;
+    private LongReference _maxClampedValue = default(LongReference);
 
     public virtual long ClampValue(long value)
     {
diff --git a/Assets/SO Architecture/Variables/Clamped/SByteClampedVariable.cs b/Assets/SO Architecture/Variables/Clamped/SByteClampedVariable.cs
@@ -10,9 +10,9 @@ public class SByteClampedVariable : SByteVariable, IClampedVariable<sbyte, SByte
     public SByteVariable MaxValue { get { return _maxClampedValue; } }
 
     [SerializeField]
-    private SByteVariable _minClampedValue;
+    private SByteVariable _minClampedValue = default(SByteVariable);
     [SerializeField]
-    private SByteVariable _maxClampedValue;
+    private SByteVariable _maxClampedValue = default(SByteVariable);
 
     public virtual sbyte ClampValue(sbyte value)
     {
diff --git a/Assets/SO Architecture/Variables/Clamped/ShortClampedVariable.cs b/Assets/SO Architecture/Variables/Clamped/ShortClampedVariable.cs
@@ -10,9 +10,9 @@ public class ShortClampedVariable : ShortVariable, IClampedVariable<short, Short
     public ShortReference MaxValue { get { return _maxClampedValue; } }
 
     [SerializeField]
-    private ShortReference _minClampedValue;
+    private ShortReference _minClampedValue = default(ShortReference);
     [SerializeField]
-    private ShortReference _maxClampedValue;
+    private ShortReference _maxClampedValue = default(ShortReference);
 
     public virtual short ClampValue(short value)
     {
diff --git a/Assets/SO Architecture/Variables/Clamped/UIntClampedVariable.cs b/Assets/SO Architecture/Variables/Clamped/UIntClampedVariable.cs
@@ -10,9 +10,9 @@ public class UintClampedVariable : UIntVariable, IClampedVariable<uint, UIntVari
     public UIntVariable MaxValue { get { return _maxClampedValue; } }
 
     [SerializeField]
-    private UIntVariable _minClampedValue;
+    private UIntVariable _minClampedValue = default(UIntVariable);
     [SerializeField]
-    private UIntVariable _maxClampedValue;
+    private UIntVariable _maxClampedValue = default(UIntVariable);
 
     public virtual uint ClampValue(uint value)
     {
diff --git a/Assets/SO Architecture/Variables/Clamped/ULongClampedVariable.cs b/Assets/SO Architecture/Variables/Clamped/ULongClampedVariable.cs
@@ -10,9 +10,9 @@ public class UlongClampedVariable : ULongVariable, IClampedVariable<ulong, ULong
     public ULongVariable MaxValue { get { return _maxClampedValue; } }
 
     [SerializeField]
-    private ULongVariable _minClampedValue;
+    private ULongVariable _minClampedValue = default(ULongVariable);
     [SerializeField]
-    private ULongVariable _maxClampedValue;
+    private ULongVariable _maxClampedValue = default(ULongVariable);
 
     public virtual ulong ClampValue(ulong value)
     {
diff --git a/Assets/SO Architecture/Variables/Clamped/UShortClampedVariable.cs b/Assets/SO Architecture/Variables/Clamped/UShortClampedVariable.cs
@@ -10,9 +10,9 @@ public class UshortClampedVariable : UShortVariable, IClampedVariable<ushort, US
     public UShortVariable MaxValue { get { return _maxClampedValue; } }
 
     [SerializeField]
-    private UShortVariable _minClampedValue;
+    private UShortVariable _minClampedValue = default(UShortVariable);
     [SerializeField]
-    private UShortVariable _maxClampedValue;
+    private UShortVariable _maxClampedValue = default(UShortVariable);
 
     public virtual ushort ClampValue(ushort value)
     {

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@ public abstract class GameEventBase<T> : GameEventBase, IGameEvent<T>, IStackTra`
`7`	`7`	`private readonly List<System.Action<T>> _typedActions = new List<System.Action<T>>();`
`8`	`8`
`9`	`9`	`[SerializeField]`
`10`		`- protected T _debugValue;`
	`10`	`+ protected T _debugValue = default(T);`
`11`	`11`
`12`	`12`	`public void Raise(T value)`
`13`	`13`	`{`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`	`public class DamageDealer : MonoBehaviour`
`6`	`6`	`{`
`7`	`7`	`[SerializeField]`
`8`		`- private FloatReference _damageAmount;`
	`8`	`+ private FloatReference _damageAmount = default(FloatReference);`
`9`	`9`
`10`	`10`	`private void OnTriggerEnter(Collider other)`
`11`	`11`	`{`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`	`public class DamageDealerWithEvent : DamageDealer`
`6`	`6`	`{`
`7`	`7`	`[SerializeField]`
`8`		`- private GameEvent _onDamagedEvent;`
	`8`	`+ private GameEvent _onDamagedEvent = default(GameEvent);`
`9`	`9`
`10`	`10`	`protected override void DealDamage(UnitHealth target)`
`11`	`11`	`{`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`	`public class Disabler : MonoBehaviour`
`6`	`6`	`{`
`7`	`7`	`[SerializeField]`
`8`		`- private GameObjectCollection _targetSet;`
	`8`	`+ private GameObjectCollection _targetSet = default(GameObjectCollection);`
`9`	`9`
`10`	`10`	`public void DisableRandom()`
`11`	`11`	`{`
Original file line number	Diff line number	Diff line change
`@@ -6,11 +6,11 @@`
`6`	`6`	`public class ImageFillSetter : MonoBehaviour`
`7`	`7`	`{`
`8`	`8`	`[SerializeField]`
`9`		`- private FloatReference _variable;`
	`9`	`+ private FloatReference _variable = default(FloatReference);`
`10`	`10`	`[SerializeField]`
`11`		`- private FloatReference _maxValue;`
	`11`	`+ private FloatReference _maxValue = default(FloatReference);`
`12`	`12`	`[SerializeField]`
`13`		`- private Image _imageTarget;`
	`13`	`+ private Image _imageTarget = default(Image);`
`14`	`14`
`15`	`15`	`private void Update()`
`16`	`16`	`{`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`	`public class KeyboardMover : MonoBehaviour`
`6`	`6`	`{`
`7`	`7`	`[SerializeField]`
`8`		`- private FloatReference _moveSpeed;`
	`8`	`+ private FloatReference _moveSpeed = default(FloatReference);`
`9`	`9`
`10`	`10`	`private void Update()`
`11`	`11`	`{`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`	`public class ObjectAdder : MonoBehaviour`
`6`	`6`	`{`
`7`	`7`	`[SerializeField]`
`8`		`- private GameObjectCollection _targetCollection;`
	`8`	`+ private GameObjectCollection _targetCollection = default(GameObjectCollection);`
`9`	`9`
`10`	`10`	`private void OnEnable()`
`11`	`11`	`{`