DTS: surplus flashrom call can cause uncontrolled firmware overwirtes

[DaniilKl]

Component

Dasharo Tools Suite

Device

other

Dasharo version

-

Dasharo Tools Suite version

v2.7.3

Test case ID

-

Brief summary

DTS has a flashrom call that can overwrite regions written by previous flashrom calls.

How reproducible

Depends on https://github.com/Dasharo/dts-scripts/blob/3b88b776b92559aaa0357d688b75d38bdfee1e2c/scripts/dasharo-deploy.sh#L971

How to reproduce

Run, for example, a transition from Dasharo (coreboot+UEFI) to Dasharo (cporeboot+Heads) on MSI Z690 DDR5 and check DTS profile.

Expected behavior

We need a clear logic implementation and tests.

Actual behavior

Currently we can have multiple flashrom calls because of this:

flashrom -p internal --ifd -i bios -i fd -i me -w /tmp/biosupdate 0
flashrom -p internal --ifd -i bios -i fd -i me -w /tmp/biosupdate 0

And the actual behaviour is not well controlled and tested.

Screenshots

No response

Additional context

Was detected here: https://github.com/Dasharo/open-source-firmware-validation/pull/1203/changes#r2707488177 .

Solutions you've tried

No response